Ai gf by lueckpeter76-lgtm · Pull Request #315 · siddharthvaddem/openscreen

lueckpeter76-lgtm · 2026-04-04T00:22:20Z

Pull Request Template

Description

Motivation

Type of Change

Related Issue(s)

Screenshots / Video

Screenshot (if applicable):

![Screenshot Description](path/to/screenshot.png)

Video (if applicable):

<video src="path/to/video.mp4" controls width="600"></video>

Testing

Checklist

I have performed a self-review of my code.
I have added any necessary screenshots or videos.
I have linked related issue(s) and updated the changelog if applicable.

Thank you for contributing!

siddharthvaddem#181)

…ommon terms in English, Spanish, and Chinese.

feat: add fullscreen video player

- Add useCameraDevices hook to enumerate video input devices - Update useScreenRecorder to support webcamDeviceId selection - Add device selector UI above HUD bar (mic + webcam, hover-to-expand) - All selectors and HUD bar are absolute-positioned to prevent layout shifts - Increase HUD window to 600x200px to accommodate device panels - Add unit tests for useCameraDevices hook

…n window

…ll clipping

- useCameraDevices: remove selectedDeviceId from useEffect deps (use ref instead) - useCameraDevices: fall back to first available device when selected device is unplugged - i18n: add missing keys (audio.defaultMicrophone, webcam.defaultCamera, webcam.searching) to en/es/zh-CN - LaunchWindow: replace hardcoded strings with t() i18n calls - tests: add afterEach(vi.resetAllMocks()), improve permission test assertions, add stale device fallback test

- LaunchWindow: expose isLoading/error from useCameraDevices; show 'Searching...' only while enumeration is in flight, 'Camera unavailable' on error, 'No camera found' when list is empty (fixes perpetual loading state) - LaunchWindow: keep <select> always mounted (sr-only when collapsed) and expand panel on focus as well as hover; fixes keyboard inaccessibility for both mic and webcam selectors - i18n: add webcam.noneFound and webcam.unavailable to en/es/zh-CN locales

…nified select, test quality) - useCameraDevices: remove getUserMedia label probe to avoid conflict with useScreenRecorder acquiring the real stream; use enumerateDevices only and fall back to 'Camera <id>' for unlabeled devices; gate effect on enabled flag - LaunchWindow: fix selectedCameraLabel to reflect loading/error/empty states in the collapsed view (was always showing 'Default Camera') - LaunchWindow: unify webcam <select> to a single always-mounted element (sr-only when unavailable); mirrors the mic selector pattern - useCameraDevices.test.ts: re-seed mockGetUserMedia in beforeEach after vi.resetAllMocks(); update permission test to assert fallback label behavior

…r test - LaunchWindow: render sr-only <select> when webcamExpanded but cameraDevices.length === 0 (loading/error/empty), so keyboard users always have a focusable element even in no-camera states - useCameraDevices.test: add error-branch test asserting error message, empty devices array and isLoading=false when enumerateDevices rejects

…ndows

…-selector-optimization feat: added webcam source selector and optimized horizontal UI

…ding-windows fix: prevent double-finalize race condition in restartRecording on Windos

coderabbitai · 2026-04-04T00:22:37Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 104b8ec5-d448-4a9d-b160-d54b4a3b88f2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b101820ab8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-04-04T00:27:18Z

electron/main.ts

+	ipcMain.handle("set-locale", (_, locale: string) => {
+		setMainLocale(locale);
+		setupApplicationMenu();
+		updateTrayMenu();


Preserve tray recording mode when locale changes

The set-locale IPC handler rebuilds the tray menu with updateTrayMenu() but does not pass the current recording state, so it falls back to recording = false. If a user changes language while actively recording (the launch HUD allows this), the tray menu is reset to the idle actions and loses the Stop Recording entry until another recording-state update arrives.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-04-04T00:27:18Z

src/contexts/I18nContext.tsx

+	useEffect(() => {
+		document.documentElement.lang = locale;
+	}, [locale]);


Sync initial locale with Electron main process

The provider reads a persisted locale on startup, but this effect only updates document.documentElement.lang; it never notifies the main process unless the user manually changes language via setLocale. That means a saved non-English preference can render the React UI localized while app menu/tray/dialog strings in the main process remain English for the session start.

Useful? React with 👍 / 👎.

siddharthvaddem · 2026-04-04T06:02:46Z

can we add a better pr description of goal and objective and proof of it workingand tested

siddharthvaddem and others added 21 commits March 21, 2026 17:06

Merge feat(export): allow re-saving exported video on dialog cancel (PR

3d680e8

siddharthvaddem#181)

lang support

4a29906

move project settings to top

7aca8b8

movable camera pip

cbbe2d7

improved vertical split gated behind 9:16

a8bb0e8

feat: add fullscreen video player

5d561ff

feat: Implement PlaybackControls component and add i18n files for c…

eae3f11

…ommon terms in English, Spanish, and Chinese.

Merge pull request siddharthvaddem#244 from ateendra24/fix-issue-226

e35780b

feat: add fullscreen video player

fix: restore flex layout to ensure HUD renders in transparent Electro…

317089d

…n window

fix: use fixed positioning for HUD and device selectors to avoid h-fu…

e72851d

…ll clipping

fix: equalize badge heights and reduce window to 160px

a9222c9

fix: enforce identical badge height with h-[36px] on both selectors

fed5a44

version bump

2f36160

fix: prevent double-finalize race condition in restartRecording on Wi…

846cf71

…ndows

Merge pull request siddharthvaddem#249 from EtienneLescot/feat/webcam…

3061c14

…-selector-optimization feat: added webcam source selector and optimized horizontal UI

Merge pull request siddharthvaddem#293 from abres33/fix/restart-recor…

b101820

…ding-windows fix: prevent double-finalize race condition in restartRecording on Windos

chatgpt-codex-connector bot reviewed Apr 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ai gf#315

Ai gf#315
lueckpeter76-lgtm wants to merge 21 commits intosiddharthvaddem:fix/pr-181-conflictsfrom
lueckpeter76-lgtm:main

lueckpeter76-lgtm commented Apr 4, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Apr 4, 2026

Review skipped

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Apr 4, 2026

Uh oh!

chatgpt-codex-connector bot Apr 4, 2026

Uh oh!

siddharthvaddem commented Apr 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

lueckpeter76-lgtm commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Template

Description

Motivation

Type of Change

Related Issue(s)

Screenshots / Video

Testing

Checklist

Uh oh!

coderabbitai bot commented Apr 4, 2026

Review skipped

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Apr 4, 2026

Choose a reason for hiding this comment

Uh oh!

siddharthvaddem commented Apr 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lueckpeter76-lgtm commented Apr 4, 2026 •

edited

Loading