Revert "fix: prevent double-finalize race condition in restartRecording on Windos"

[lueckpeter76-lgtm]

Reverts #293

Summary by CodeRabbit

• Refactor
  • Optimized screen recorder restart control flow for improved internal state management.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: db41721c-3730-4f08-bb23-bdf480fbd0c1

📥 Commits

Reviewing files that changed from the base of the PR and between b101820 and f972556.

📒 Files selected for processing (1)

• src/hooks/useScreenRecorder.ts

💤 Files with no reviewable changes (1)

• src/hooks/useScreenRecorder.ts

---

📝 Walkthrough

Walkthrough

Removed a single line that explicitly disabled auto-finalization when restarting recording. The behavior is maintained through existing cleanup effects and stop event handlers, eliminating redundant state management in the restart control flow.

Changes

Cohort / File(s)	Summary
Recording Restart Logic src/hooks/useScreenRecorder.ts	Removed explicit allowAutoFinalize.current = false assignment during restartRecording() since the same state is reset via cleanup effects and checked in the stop event handler, simplifying the restart control flow.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• fix: prevent double-finalize race condition in restartRecording on Windos #293: Directly related — that PR added the allowAutoFinalize.current = false assignment to prevent double-finalize on restart, while this PR removes it as the behavior is now redundantly managed elsewhere.

Suggested reviewers

• siddharthvaddem

Poem

🐰 A line removed, so clean and neat,
No double-finalize, the restart's sweet!
The cleanup and handlers have got the flow,
Less code to check, less logic to know! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete and minimal. It only references the issue being reverted without providing the required sections such as motivation, type of change, testing details, or proper context.	Expand the description to include motivation explaining why the revert is necessary, specify the type of change, and describe how the changes were tested before merging.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the pull request as a revert of a specific previous commit, which matches the single-line code change removing the allowAutoFinalize assignment.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f972556443

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".