fix: Refresh not triggered if the access token is not also known, which limits its purpose #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly send auth token too for the backends that might require it.
commit: |
|
Fix is incomplete - logout doesn't clear refresh cookie so the user re-authenticates on each visit. |
… is overwritten by unemptied cookie.
|
Tested with my local setup, everything works fine now. |
phoenix-ru
reviewed
Sep 12, 2024
Comment on lines
-44
to
46
| provider.token.signInResponseTokenPointer | ||
| )}. Tried to find token at ${provider.token.signInResponseTokenPointer | ||
| } in ${JSON.stringify(response)}` |
There was a problem hiding this comment.
Could you please not apply stylistic changes? Thanks
| @@ -57,8 +58,7 @@ export default defineNuxtPlugin({ | |||
| console.error( | |||
| `Auth: string token expected, received instead: ${JSON.stringify( | |||
| extractedRefreshToken | |||
| )}. Tried to find token at ${ | |||
| provider.refresh.token.signInResponseRefreshTokenPointer | |||
| )}. Tried to find token at ${provider.refresh.token.signInResponseRefreshTokenPointer | |||
Comment on lines
+92
to
+98
| useCookie(config.token.cookieName, { | ||
| maxAge: 0, | ||
| domain: config.token.cookieDomain, | ||
| sameSite: config.token.sameSiteAttribute, | ||
| secure: config.token.secureCookieAttribute, | ||
| httpOnly: config.token.httpOnlyCookieAttribute | ||
| }).value = null |
There was a problem hiding this comment.
I've been trying to understand why is this required - could you please clarify that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#890 [second part]
❓ Type of change
📚 Description
The refresh logic should be triggered if the refresh token is known.
Some backends might require both tokens for a refresh, but this is not default behavior.
Refresh tokens are long-lasting and usually expire after access tokens, so requiring both for a successful refresh should be optional.
📝 Checklist