chore: upgrade to nitro 2.10, preparing for nitropack ecosystem switch from nitropack to nitro
#942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h from nitropack to nitro
commit: |
|
@phoenix-ru / @zoey-kaiser: Opening this to raise awareness of the above potential issues. Feel free to merge as is / close / put into another dep-upgrade PR. |
zoey-kaiser
approved these changes
Nov 12, 2024
phoenix-ru
requested changes
Nov 14, 2024
There was a problem hiding this comment.
There are multiple duplicate packages in the lockfile (majority wasn't duplicated prior to this PR)
At the very least it will cause undefined behaviour when developing nuxt-auth.
@BracketJohn which command did you use to update nitropack? I think a deduplication run needs to happen on the lockfile
| @@ -260,6 +260,10 @@ packages: | |||
| resolution: {integrity: sha512-BcYH1CVJBO9tvyIZ2jVeXgSIMvGZ2FDRvDdOIVQyuklNKSsx+eppDEBq/g47Ayw+RqNFE+URvOShmf+f/qwAlA==} | |||
| engines: {node: '>=6.9.0'} | |||
|
|
|||
| '@babel/[email protected]': | |||
There was a problem hiding this comment.
There are duplicates in @babel packages
| @@ -599,6 +672,12 @@ packages: | |||
| cpu: [arm64] | |||
| os: [android] | |||
|
|
|||
| '@esbuild/[email protected]': | |||
| @@ -1570,6 +1826,15 @@ packages: | |||
| rollup: | |||
| optional: true | |||
|
|
|||
| '@rollup/[email protected]': | |||
There was a problem hiding this comment.
And two major versions of @rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
N/A
❓ Type of change
📚 Description
This PR upgrades
[email protected]to[email protected]. This resolves two issues:[email protected]relies on an unimport-version that augments the vue-runtime-core types, which was deprecated with vue 3.5: fix: dropdeclare module '@vue/runtime-core'unjs/unimport#359[email protected]changes the package structure for an upcoming switch to the new namenitrowith the release ofv3. So if people upgrade to latest nuxt and in turn also upgrade all sub-deps to latest nitro, the import thatnuxt-authhas fromnitropackwill break (see changes I made here)See https://github.com/nitrojs/nitro/releases/tag/v2.10.0 for more on the namespace change.
📝 Checklist