feat: improve talos upgrade command - #12751
Open
pranav767 wants to merge 1 commit into
Open
Conversation
|
This PR is stale because it has been open 45 days with no activity. |
pranav767
marked this pull request as draft
June 11, 2026 09:05
pranav767
force-pushed
the
feat/improve-talos-upgrade-command
branch
from
June 12, 2026 04:42
778fda8 to
8940a40
Compare
pranav767
changed the title
pranav767
force-pushed
the
feat/improve-talos-upgrade-command
branch
from
June 15, 2026 15:09
8940a40 to
a2f6b9d
Compare
2 tasks
pranav767
force-pushed
the
feat/improve-talos-upgrade-command
branch
2 times, most recently
from
July 24, 2026 13:57
6963da1 to
ded09cf
Compare
Contributor
Author
|
@smira , Might be a little late to the party Per Node Image Resolution involves
As a basic criteria new flags created
|
pranav767
marked this pull request as ready for review
July 26, 2026 09:53
…per-node image resolution for building upgrade url
Contributor
Author
|
Dropping in test upgrade logs I wanted to test out if I do a upgrade to certain version and schematic and on next say just version upgrade it should pick up the new changed schematic rather than the one during the startup, I was not able to try this out because |
pranav767
commented
Jul 26, 2026
|
|
||
| // If every derived component is set explicitly, no per-node state is needed: the image is uniform. | ||
| if upgradeCmdFlags.schematic != "" && upgradeCmdFlags.platform != "" && | ||
| upgradeCmdFlags.secureBootChanged && upgradeCmdFlags.factoryChanged && upgradeCmdFlags.talosVersion != ""{ |
Contributor
Author
There was a problem hiding this comment.
We can maybe remove this talosversion check as well to get a quick image url ref, as version will remain same for all nodes from tag AFAIK
pranav767
force-pushed
the
feat/improve-talos-upgrade-command
branch
from
July 26, 2026 10:05
ded09cf to
d9593ec
Compare
pranav767
commented
Jul 26, 2026
| // machine was installed from an Image Factory image, so its absence is not an error. | ||
| schematic, err := safe.StateGetByID[*runtimeres.ImageFactorySchematic](ctx, c.COSI, runtimeres.ImageFactorySchematicID) | ||
| if err != nil { | ||
| if state.IsNotFoundError(err) || status.Code(err) == codes.PermissionDenied { |
Contributor
Author
There was a problem hiding this comment.
On older Talos versions (< 1.14) this resource type doesn't exist at all, so the API returns PermissionDenied rather than NotFound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Resolves #12152
What? (description)
--imageparameter, keep as legacy--factory, --platform,--secureBoot,--schematicWhy? (reasoning)
--imagewith component-based flags that create image url from machine state / specified requirements and validate secure-boot/platform transitions.Acceptance
Please use the following checklist:
make conformance)make fmt)make lint)make docs)make unit-tests)Trying this out on a test node:
Post upgrade check extensions & upgraded version