chore: bump to containerd config version 3#13626
Open
winterqt wants to merge 1 commit into
Open
Conversation
Closes siderolabs#13290. Going through the configuration migration code [0], doing some cursory greps and running tests, I *think* there's nothing to migrate in here or the extensions in siderolabs/extensions. [0]: https://github.com/containerd/containerd/blob/e96fd14b81ba273a38d0506056669ba571fea0bf/cmd/containerd/server/config/config.go#L219-L339 Signed-off-by: Winter <winter@winter.cafe>
shanduur
added
integration/extensions
Member
|
Thank you for the PR, but I would rather hold on that, as we need to give this a bigger scope for user-managed patches as well. I will link it to #12442 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes #13290.
Going through the configuration migration code 0, doing some cursory greps and running tests, I think there's nothing to migrate in here or the extensions in siderolabs/extensions.
Acceptance
Please use the following checklist:
make conformance) -- failed because I don't sign my commitsmake fmt)make lint)make docs)make unit-tests)