Skip to content

fix: ignore insecure-only imager assets#13825

Open
kastakhov wants to merge 1 commit into
siderolabs:mainfrom
kastakhov:imager-imageref-issue
Open

fix: ignore insecure-only imager assets#13825
kastakhov wants to merge 1 commit into
siderolabs:mainfrom
kastakhov:imager-imageref-issue

Conversation

@kastakhov

Copy link
Copy Markdown
Contributor

Pull Request

What? (description)

Fix imager asset presence checks so forceInsecure alone does not make a container asset configured.

Changes:

  • add ContainerAsset.IsSet() based on source fields only
  • default baseInstaller when only forceInsecure is set
  • skip image cache extraction when no image cache source is set
  • add tests for insecure-only assets and base installer defaulting

Why? (reasoning)

imager --insecure can set imageCache.forceInsecure: true without an image cache image. That made imager try to pull an empty image ref.

Closes #13824

Acceptance

Please use the following checklist:

  • you linked an issue (if applicable)
  • you included tests (if applicable)
  • you ran conformance (make conformance)
  • you formatted your code (make fmt)
  • you linted your code (make lint)
  • you generated documentation (make docs)
  • you ran unit-tests (make unit-tests)

Targeted tests run:

GOCACHE=/tmp/talos-go-cache go test ./pkg/imager/profile ./pkg/imager

@github-project-automation github-project-automation Bot moved this to To Do in Planning Jul 21, 2026
@talos-bot talos-bot moved this from To Do to In Review in Planning Jul 21, 2026
@kastakhov kastakhov changed the title fix(imager): ignore insecure-only assets fix: ignore insecure-only imager assets Jul 21, 2026
@kastakhov
kastakhov force-pushed the imager-imageref-issue branch from 1c2d5cb to cccc3ef Compare July 21, 2026 21:58
Signed-off-by: kastakhov <16296930+kastakhov@users.noreply.github.com>
@kastakhov
kastakhov force-pushed the imager-imageref-issue branch from cccc3ef to f0a4e51 Compare July 21, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

imager --insecure treats empty image cache as configured

2 participants