Skip to content

backports: for v1.13.9 - #14060

Open
smira wants to merge 6 commits into
siderolabs:release-1.13from
smira:backports/v1.13.9
Open

backports: for v1.13.9#14060
smira wants to merge 6 commits into
siderolabs:release-1.13from
smira:backports/v1.13.9

Conversation

@smira

@smira smira commented Aug 17, 2026

Copy link
Copy Markdown
Member

Copilot AI lite review requested due to automatic review settings August 17, 2026 16:26
@github-project-automation github-project-automation Bot moved this to To Do in Planning Aug 17, 2026
@talos-bot talos-bot moved this from To Do to In Review in Planning Aug 17, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aggregates backports targeted for the v1.13.9 line, combining runtime fixes (nftables netlink buffering, extension IPC namespace behavior, and try-mode config apply robustness) with the usual release/version bumps (kernel/Go versions, tool images, and Go module dependencies).

Changes:

  • Size nftables netlink send/receive buffers and reuse a lasting netlink connection per controller run; add a regression test for large rulesets.
  • Run extension services in the host IPC namespace and handle SetConfig(nil) by deleting the machine config resource; add an integration regression test for try-mode apply without prior config.
  • Bump kernel/Go version strings and update tools/pkgs image tags and various Go module dependencies.

Reviewed changes

Copilot reviewed 14 out of 18 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tools/structprotogen/go.sum Updates x/* dependency sums for structprotogen tool module.
tools/structprotogen/go.mod Bumps golang.org/x/* dependencies for structprotogen.
tools/redactgen/go.sum Updates x/* dependency sums for redactgen tool module.
tools/redactgen/go.mod Bumps golang.org/x/* dependencies for redactgen.
tools/go.sum Updates toolchain dependency sums for the tools module.
tools/go.mod Bumps tools module Go version and indirect x/* dependencies.
pkg/machinery/gendata/data/tools Updates embedded tools image tag metadata.
pkg/machinery/gendata/data/pkgs Updates embedded pkgs image tag metadata.
pkg/machinery/constants/constants.go Bumps default kernel version and reported Go build version.
Makefile Updates TOOLS/PKGS image tags used in builds.
internal/integration/provision/maintenance_basic.go Adds integration regression coverage for try-mode apply with no prior config.
internal/app/machined/pkg/system/services/extension.go Shares host IPC namespace with extension service containers.
internal/app/machined/pkg/runtime/v1alpha2/v1alpha2_state.go Allows SetConfig(nil) by destroying the config resource instead of panicking.
internal/app/machined/pkg/controllers/network/nftables_chain.go Sizes nftables netlink socket buffers and reuses a lasting connection.
internal/app/machined/pkg/controllers/network/nftables_chain_test.go Adds a large ruleset regression test to validate buffering fix.
hack/release.toml Updates release note component versions (and Go version text).
go.sum Updates root module dependency sums (x/* bumps).
go.mod Bumps root module dependencies (x/* bumps).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread pkg/machinery/constants/constants.go
Comment thread hack/release.toml
@github-project-automation github-project-automation Bot moved this from In Review to Approved in Planning Aug 17, 2026
@smira
smira force-pushed the backports/v1.13.9 branch 2 times, most recently from bb1a752 to 940a6b0 Compare August 17, 2026 17:47
@smira smira added integration/release-gate Run all release-gate integration tests integration/aws-nvidia-oss-lts Run AWS NVIDIA OSS LTS driver tests (all architectures) integration/aws-nvidia-oss-production Run AWS NVIDIA OSS production driver tests (all architectures) labels Aug 17, 2026
@smira
smira force-pushed the backports/v1.13.9 branch from 940a6b0 to 01e0c7d Compare August 18, 2026 07:02
@smira smira added integration/provision-2 Run provision integration tests for track 2 (current→current, extra-cmdline) and removed integration/aws-nvidia-oss-lts Run AWS NVIDIA OSS LTS driver tests (all architectures) integration/aws-nvidia-oss-production Run AWS NVIDIA OSS production driver tests (all architectures) integration/release-gate Run all release-gate integration tests labels Aug 18, 2026
@smira
smira force-pushed the backports/v1.13.9 branch from 01e0c7d to 7b3a614 Compare August 18, 2026 10:59
smira added 6 commits August 18, 2026 16:28
Also pull in new Linux & pkgs.

Update dependencies to clear Grype report.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Without this fix, kernel default send/receive buffers are used which
might not be enough, as the full transaction of replacing the firewall
is atomic, and basically we need to send (and then receive ACKs) for
every piece of the firewall.

Provide proper sizing for send/receive buffers.
Also, create one connection per controller run and use that.

Fixes siderolabs#14001

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 87bfa70)
There is an interaction between multipath-tools, devicemapper and udevd
which sometimes crosses the extension service and the host when used via
CSI.

Allow to share IPC namespace so that the SysV locks works across the
boundary of the extension service.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit 1c50b73)
Without this fix, Talos panics while trying to set the config to `nil`
value. This is an edge case specifically for naving no machine config
prior to the requested try operation.

Add a regression test in the maintenance test.

Fixes siderolabs#14044

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
(cherry picked from commit be6b963)
Persist them on disk for GHA to pick them up.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Use the latest Kubernetes.

Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
@smira
smira force-pushed the backports/v1.13.9 branch from 7b3a614 to 9ade215 Compare August 18, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration/provision-2 Run provision integration tests for track 2 (current→current, extra-cmdline) status/ok-to-test

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

5 participants