Skip to content

Feat(URL): Update url endpoints#60

Open
Guiliano99 wants to merge 7 commits intosiemens:mainfrom
Guiliano99:UpdateURLEndpoints
Open

Feat(URL): Update url endpoints#60
Guiliano99 wants to merge 7 commits intosiemens:mainfrom
Guiliano99:UpdateURLEndpoints

Conversation

@Guiliano99
Copy link
Contributor

@Guiliano99 Guiliano99 commented Mar 2, 2026

Add additional endpoints for the reaching the MockCA.

Description

  • Add the prefixes /<pkibody_type>, /issuing/<pkibody_type>, /.well-known/cmp/p/<pkibody_type>
  • Add new endpoints for the reaching the MockCA.
  • As an example OpenSSL append the PKIBody type to the -server argument.
  • Add new config variable ADD_PKIBODY_TYPE_2_URL to add the pkibody name to the url, if that config variable is set to True.

TODO

  • Add additional test cases for testing, if only the correct PKIBody type is accepted for each URL.

Motivation and Context

  • Some implementations uses the URL endpoints define in RFC9480 and RFC9810

How Has This Been Tested?

  • Added new unit test for checking the unit test endpoint.
  • Tested to run the test cases again against the MockCA with the ADD_PKIBODY_TYPE_2_URL variable set to True.

@Guiliano99 Guiliano99 marked this pull request as ready for review March 2, 2026 14:28
@Guiliano99 Guiliano99 requested a review from ralienpp as a code owner March 2, 2026 14:28
@ralienpp
Copy link
Collaborator

ralienpp commented Mar 9, 2026

This looks OK but the naming could be better, because "type 2" is not an evident meaning. What is the essence of this thing? Add a suffix? Expand or augment the original URL? I'd rather use these keywords instead of "type 2".

@Guiliano99
Copy link
Contributor Author

This looks OK but the naming could be better, because "type 2" is not an evident meaning. What is the essence of this thing? Add a suffix? Expand or augment the original URL? I'd rather use these keywords instead of "type 2".

It expands the original URL, with the PKIBody type names, like for genm it would be added like this http://127.0.0.1:5000/issuing/genm. i wanted to also add it in the config for easly updting the default url. Becasue OpenSSL does it. But some other implementation might not.

@Guiliano99
Copy link
Contributor Author

Guiliano99 commented Mar 9, 2026

@ralienpp I think you are right: What about APPEND_PKIBODY_AS_URL_SUFFIX?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants