Added Talkback Accessibility Strings in Settings Menus - #14931
Open
Jinko48 wants to merge 3 commits into
Open
Conversation
…ings in settings menus
Author
|
Tested talkback on virtual device, and it seems to use "Go Back" for the English text to speech. As far as I can tell it seems to work for other languages as well ("Volver" at least in Spanish). |
updated LabSettingsFragment.kt;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription
Fixes #14924
I added accessibility strings for the menus that were defaulting to
null. I just set them to the same string fromapp/src/main/res/values/strings.xmlthatAppSettingsFragment.ktis using so it would work across locales and languages.I haven't tested this on a virtual device or personal device yet, but I can attempt that before merging if necessary.The build does run to completion.