Skip to content

Improve photo quality with enhanced AVCapturePhotoOutput settings #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve photo quality with enhanced AVCapturePhotoOutput settings #6135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions Signal/src/ViewControllers/Photos/CameraCaptureSession.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1486,12 +1486,15 @@ private class PhotoCapture {
let avCaptureOutput = AVCapturePhotoOutput()

var flashMode: AVCaptureDevice.FlashMode = .off

init() {
init() {
avCaptureOutput.isLivePhotoCaptureEnabled = false
avCaptureOutput.isHighResolutionCaptureEnabled = true
}

if #available(iOS 13.0, *) {

avCaptureOutput.maxPhotoQualityPrioritization = .quality
}
}
private var photoProcessors: [Int64: PhotoProcessor] = [:]

func takePhoto(delegate: PhotoCaptureDelegate, captureOrientation: AVCaptureVideoOrientation, captureRect: CGRect) {
Expand All @@ -1502,10 +1505,19 @@ private class PhotoCapture {

avCaptureConnection.videoOrientation = captureOrientation

let photoSettings = AVCapturePhotoSettings()
let photoSettings = AVCapturePhotoSettings()
photoSettings.flashMode = flashMode
photoSettings.isHighResolutionPhotoEnabled = true

if #available(iOS 13.0, *) {

photoSettings.photoQualityPrioritization = .quality
}

if avCaptureOutput.isAutoRedEyeReductionSupported {
photoSettings.isAutoRedEyeReductionEnabled = true
}

let photoProcessor = PhotoProcessor(delegate: delegate, captureRect: captureRect) { [weak self] in
self?.photoProcessors[photoSettings.uniqueID] = nil
}
Expand Down