Remove collector repositories from the repo lists#371
Conversation
Remove repositories for which the specification doesn't apply.
| @@ -1,7 +1,3 @@ | |||
| https://github.com/signalfx/splunk-otel-collector | |||
| https://github.com/signalfx/splunk-otel-collector-operator | |||
There was a problem hiding this comment.
this repository is archived.
| https://github.com/signalfx/splunk-otel-collector | ||
| https://github.com/signalfx/splunk-otel-collector-operator | ||
| https://github.com/signalfx/splunk-otel-collector-chart | ||
| https://github.com/signalfx/splunk-otel-collector-heroku |
There was a problem hiding this comment.
this repository is not in scope of the specification as it is a packaging solution for heroku.
There was a problem hiding this comment.
Cannot it still follow https://github.com/signalfx/gdi-specification/blob/main/specification/repository.md?
| @@ -1,7 +1,3 @@ | |||
| https://github.com/signalfx/splunk-otel-collector | |||
| https://github.com/signalfx/splunk-otel-collector-operator | |||
| https://github.com/signalfx/splunk-otel-collector-chart | |||
There was a problem hiding this comment.
this repository follows helm best practices and updates, and will not be tied to the specification.
There was a problem hiding this comment.
Cannot it still follow https://github.com/signalfx/gdi-specification/blob/main/specification/repository.md?
| @@ -1,7 +1,3 @@ | |||
| https://github.com/signalfx/splunk-otel-collector | |||
There was a problem hiding this comment.
this software acts as middleware ETL tooling and is not tied to the specification requirements of the specification.
There was a problem hiding this comment.
Hm... The collector has been in scope so far. Some parts might not apply to it, but other parts specificly target collector e.g. https://github.com/signalfx/gdi-specification/blob/main/specification/configuration.md#kubernetes-package-management-solutions
There was a problem hiding this comment.
OK let's leave it in then, it was my understanding the specification doesn't apply well to the collector.
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
This seems good to me.
The collector seems like a core GDI piece that wants to stay consistent with the other instrumentation repos (to the best that it makes sense to). Is it a problem to keep it as part of gdi spec or is it too limiting?
Kielek
changed the title
|
@atoulme to update or close. |
4 participants
Remove repositories for which the specification doesn't apply.