POC Global Attributes implementation #1181
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val attributes: List<Attribute> get() = _attributes // Expose as immutable list | ||
|
|
||
| // this method definitely can be streamlined | ||
| operator fun set(key: Any, value: Any) { |
There was a problem hiding this comment.
IMHO, it would be better to write a function for each type. These "Any functions" are often leads into issues.
operator fun set(key: String, value: String) {
remove(key)
_attributes += Attribute.String(key, value)
}
| } | ||
|
|
||
| fun remove(key: String) { | ||
| _attributes.removeAll { it.name == key } |
There was a problem hiding this comment.
There will be always at most one element with the key.
for (i in _attributes.indices)
if (_attributes[i].name == key) {
_attributes.removeAt(i)
break
}
|
|
||
| override fun onStart(parentContext: Context, span: ReadWriteSpan) { | ||
| // Fetch the current attributes from GlobalAttributes and apply them to the span | ||
| GlobalAttributes.instance.attributes.forEach { attribute -> |
| import io.opentelemetry.sdk.trace.ReadableSpan | ||
| import io.opentelemetry.sdk.trace.SpanProcessor | ||
|
|
||
| class GlobalAttributeSpanProcessor2 : SpanProcessor { |
There was a problem hiding this comment.
Please remove GlobalAttributeSpanProcessor if possible
|
Thanks for the comments @TomasChladekSL , This is just a rough proof of concept to ensure everybody is on board with the approach, and not the final implementation. But I'll be sure to incorporate those things in the actual PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC Implementation of global attributes feature.