SnapshotProfilingConfiguration refactoring to be consistent with ProfilerConfiguration#2931
Open
robsunday wants to merge 4 commits into
Open
SnapshotProfilingConfiguration refactoring to be consistent with ProfilerConfiguration#2931robsunday wants to merge 4 commits into
robsunday wants to merge 4 commits into
Conversation
robsunday
commented
Jul 7, 2026
Contributor
Author
There was a problem hiding this comment.
[for reviewer] Changes in this file are needed to correctly create default profiler exporter
|
Tick the box to add this pull request to the merge queue (same as
|
Contributor
|
Every declarative config related PR is 1000+ lines. 😮💨 |
breedx-splk
reviewed
Jul 7, 2026
|
|
||
| private Builder() {} | ||
|
|
||
| private Builder(SnapshotProfilingConfiguration config) { |
Contributor
There was a problem hiding this comment.
the builder takes a config and the config takes a builder? what's this world coming to?
Contributor
Author
There was a problem hiding this comment.
Yeah, the world is changing and we have a new candidate to blame - a.i. ;-)
I fixed this circularity also in ProfilerConfiguration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created to make handling of SnapshotProfilingConfiguration consistent with handling of ProfilerConfiguration (see #2903)
In scope:
SnapshotProfilingEnvVarsConfigurationandSnapshotProfilingDeclarativeConfigurationare replaced by a single class -SnapshotProfilingConfigurationSnapshotProfilingConfigurationis created by a factory appropriate for the agent configuration flavor (SnapshotProfilingEnvVarsConfigurationFactory/SnapshotProfilingDeclarativeConfigurationFactory).SnapshotProfilingConfigurationis always available through ProfilerConfiguration.SUPPLIER