Feature gate ring for Miri support #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ring contains a call to
OPENSSL_cpuid_setupwhich is not supported by Miri [it can't handle most FFI].This PR feature-gates
ringso that we can buildethereum_hashingwithout it. This enables us to run the test suites fortree_hashandssz_typesusing Miri, which is increasingly important with the introduction ofunsafecode in:This change is unfortunately not backwards-compatible, as downstream users compiling with
default-features = falsemight have their build broken by the exclusion ofring(on a non-x86_64 platform). Therefore this PR necessitates a minor version bump.