Ensure light_client/updates endpoint returns spec compliant SSZ data
#7230
+17
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
eserilev
changed the title
light_client/updates endpoint returns spec compliant SSZ datalight_client/updates endpoint returns spec compliant SSZ data
eserilev
added
ready-for-review
michaelsproul
requested changes
Apr 10, 2025
common/eth2/src/types.rs
Outdated
| pub response_chunk_len: Vec<u8>, | ||
| pub response_chunk: Vec<u8>, | ||
| pub struct LightClientUpdateResponseChunk { | ||
| pub response_chunk_len: u8, |
There was a problem hiding this comment.
This is meant to be a u64 I think?
The spec says:
(
response_chunk_len: Little-endian Uint64 byte length of `response_chunk`
response_chunk: (
context: 4 byte `ForkDigest`
payload: SSZ serialized payload bytes
)
)
There was a problem hiding this comment.
thanks for catching that
michaelsproul
added
waiting-on-author
…rilev/lighthouse into light-client-updates-ssz-fix
eserilev
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #7167
Proposed Changes