feat!: Optional execution proofs #8316
Closed
+6,130
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapplion
reviewed
Oct 29, 2025
| if O::observe() { | ||
| observe_gossip_execution_proof(&execution_proof, chain)?; | ||
| } | ||
| return Err(GossipExecutionProofError::PriorKnownUnpublished); |
There was a problem hiding this comment.
Gossip has a de-duplication mechanism based on the message content. Is there a single possible ExecutionProof per subnet and slot that is valid? If yes, the observe cache feels unnecessary.
There was a problem hiding this comment.
Yep -- there is only one subnet now but there are multiple proofs for the slot. So there is a single possible ExecutionProof for a (proof_id, slot_number, beacon_block_root) combination
dapplion
reviewed
Oct 29, 2025
| peer_id: PeerId, | ||
| execution_proof: Option<Arc<ExecutionProof>>, | ||
| seen_timestamp: Duration, | ||
| }, |
There was a problem hiding this comment.
I would not touch sync for now, get the core logic in first
|
closing, spoke with team :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
This is a parallel PR to #7755 that includes more of the logic needed to for example sync.
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.