-
Notifications
You must be signed in to change notification settings - Fork 580
feat: use test containers action from scaffolding #4161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ramonpetgrave64
wants to merge
13
commits into
sigstore:main
Choose a base branch
from
ramonpetgrave64:scaffodling_test_containers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: use test containers action from scaffolding #4161
ramonpetgrave64
wants to merge
13
commits into
sigstore:main
from
ramonpetgrave64:scaffodling_test_containers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4161 +/- ##
==========================================
- Coverage 40.10% 36.33% -3.77%
==========================================
Files 155 210 +55
Lines 10044 13750 +3706
==========================================
+ Hits 4028 4996 +968
- Misses 5530 8134 +2604
- Partials 486 620 +134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
ramonpetgrave64
commented
Apr 10, 2025
close := func() {} | ||
tsaURLPrefix := os.Getenv("TSA_URL") | ||
if tsaURLPrefix == "" { // use tsa as a library instead. | ||
slog.Info("Using TSA as a library") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Ramon Petgrave <[email protected]>
Signed-off-by: Ramon Petgrave <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sigstore/rekor-tiles#38
pending sigstore/scaffolding#1544
Uses the new test_containers action to launch containers for testing purposes.
Some of this repo's code has been moved to scaffolding.
Testing
pre-submit workflows pass.
Release Note
Documentation