Backport: Fixed issue where the sort of mixins would differ in some cases#188
Open
UndefinedOffset wants to merge 1 commit intosilverleague:3.6from
Open
Backport: Fixed issue where the sort of mixins would differ in some cases#188UndefinedOffset wants to merge 1 commit intosilverleague:3.6from
UndefinedOffset wants to merge 1 commit intosilverleague:3.6from
Conversation
Member
|
Seems a 4 test fails? 🤔 |
Firesphere
approved these changes
Mar 3, 2026
Member
Firesphere
left a comment
Firesphere
left a comment
There was a problem hiding this comment.
It's okay with me, but I think we should drop support of 4.4 in favour of a 4.x version that fixes the problems raised by the tests.
Collaborator
Author
|
I agree though bumping to 4.5 which solves that issue, but raises another in the same test where it complains about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #185 for Silverstripe 4 & 5, note test failure is unrelated to changes it seems to be an issue with that one specific test itself.