BlockInformation Type Port from Web3.js#232
BlockInformation Type Port from Web3.js#232TheGreatAxios wants to merge 2 commits intosimolus3:masterfrom
Conversation
TheGreatAxios
commented
Dec 26, 2021
TheGreatAxios
commented
- Ported the BlockInformation from Web3.js
- Some of the types are strings, but can be manipulated to BigInt or Uint8List potentially
- Have not made methods for some of those potentials yet
- Have not implemented tests yet
lib/src/core/client.dart
Outdated
| var signed = await signTransaction(cred, transaction, | ||
| chainId: chainId, fetchChainIdFromNetworkId: fetchChainIdFromNetworkId); | ||
|
|
||
| print("signed: $signed"); |
There was a problem hiding this comment.
Probably a leftover from debugging?
There was a problem hiding this comment.
Possibly, I don't remember that, but it is easily removed.
|
@simolus3 Commit #71c888a..... I just pushed up has the fields for block info set as final and the removal of that print in the client. Let me know if you see anything else! |
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 71.42% 69.03% -2.40%
==========================================
Files 53 55 +2
Lines 2184 2238 +54
==========================================
- Hits 1560 1545 -15
- Misses 624 693 +69
Continue to review full report at Codecov.
|
| this.sha3Uncles, | ||
| this.size, | ||
| this.stateRoot, | ||
| this.timestamp, |
There was a problem hiding this comment.
Can timestamp be int safely?
There was a problem hiding this comment.
Yeah it should probably be a DateTime
| final String? sha3Uncles; | ||
| final String? size; | ||
| final String? stateRoot; | ||
| final String? timestamp; |
There was a problem hiding this comment.
I think we should not rush to add all the info that eth_getBlockByNumber returns without carefully choosing an appropriate data type for each field. If we make them strings and then decide to change to int, it would be a breaking change.
If we do not have resources to choose carefully, we should add only the fields we are conscious about, like this timestamp which is definitely int and not null.
4 participants
