refactor(service-config): Restructure service registration logic#1127
Conversation
| { | ||
| c.SwaggerDoc("v1", new OpenApiInfo { Title = "SimplCommerce API", Version = "v1" }); | ||
| }); | ||
| builder.Services.ConfigureModules(); |
There was a problem hiding this comment.
Some of the moved registration is not a part of the modules configuration?!!
There was a problem hiding this comment.
@hishamco Could you please point out which specific registrations you feel don't belong in the modules configuration? I'd like to understand the intended organization better.
KaranChadha10
force-pushed
the
refactor/restructure-program.cs
branch
from
80f2728 to
e651bcf
Compare
|
@hishamco comments addressed, kindly review the PR, thanks. |
| /// </summary> | ||
| /// <param name="services">The <see cref="IServiceCollection"/> to add module services to.</param> | ||
| /// <returns>The same service collection so that multiple calls can be chained.</returns> | ||
| public static IServiceCollection ConfigureModules(this IServiceCollection services) |
There was a problem hiding this comment.
I'm agree with this extension, please revert the others, coz the order sometimes is matter
KaranChadha10
force-pushed
the
refactor/restructure-program.cs
branch
from
e651bcf to
23f6cc7
Compare
KaranChadha10
force-pushed
the
refactor/restructure-program.cs
branch
from
23f6cc7 to
e74b0ee
Compare
|
Addressed pr comments, @hishamco please verify, thanks. |
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Diagnostics; | ||
| using System.IdentityModel.Tokens.Jwt; |
There was a problem hiding this comment.
Last note make sure from the added usings
There was a problem hiding this comment.
This line was already there I have just Removed ununsed usings and sorted them alphabetically
2 participants
Description
This PR contains the following points: