Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parallel deployment #80

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

dakaneye
Copy link
Contributor

@dakaneye dakaneye commented Oct 28, 2024

Updates the maven resolver version to 1.9.22 so we can support parallelizatin of the deploy. Then, set the appropriate configuration property on the session to allow for parallel deploy.

References:

@mosabua
Copy link
Member

mosabua commented Oct 28, 2024

Can you either break it up into two commits or make the commit message with shorter title and a description?

@dakaneye dakaneye changed the title Update maven-resolver version to 1.9.22 and configure parallelization Update maven-resolver version & support parallel deploy Oct 28, 2024
@dakaneye
Copy link
Contributor Author

Can you either break it up into two commits or make the commit message with shorter title and a description?

shortened a bit! Let me know if that's alright.

Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the commit message.. how about

Add support for parallel deployment

Includes the required update for maven resolver and
two new configuration properties to enable parallel 
deployment and configure parallelism.

@mosabua mosabua changed the title Update maven-resolver version & support parallel deploy Add support for parallel deployment Oct 29, 2024
Includes the required update for maven resolver and
two new configuration properties to enable parallel
deployment and configure parallelism.

Signed-off-by: Samuel Dacanay <[email protected]>
By passing Configuration in and storing as a class variable,
we can ensure that the params provided to Deployer dont
continue to expand. It simplifies the method signatures too.

Signed-off-by: Samuel Dacanay <[email protected]>
@mosabua mosabua merged commit a11eb61 into simpligility:master Oct 29, 2024
2 checks passed
@mosabua
Copy link
Member

mosabua commented Oct 29, 2024

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants