Improve accessibility of toolbar buttons#2705
Draft
putnokiabel wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The buttons in the toolbar are currently not accessible and not labeled correctly when using screen readers (e.g. VoiceOver). This is due to not using the
tooltipvalue on the underlyingIconButtonfrom Material.Changes:
tooltipvalue to the underlying button inToggleStyleButton(so it's accessible in semantics / VoiceOver)tooltipvalue inSelectHeaderStyleButtons. The current approach only allows for setting a single tooltip (same across all header style buttons) which is obviously useless for blind users. This PR fixes this by setting the tooltip to the value displayed on the button (N, H1, H2, etc).How to test:
Run an app with a toolbar via Xcode, then tap Xcode -> Open developer tool -> Accessibility, and verify that on
main, the toolbar buttons don't have tooltips (regardless of tooltips set inButtonOptions).With this PR, the user of the plugin can set tooltips via the various
ButtonOptions.Type of Change