Skip to content

fix(editor): MentionTagWrapper document swap and selection timing for @/#/$ triggers#2720

Open
dev-chetan wants to merge 52 commits into
singerdmx:masterfrom
dev-chetan:master
Open

fix(editor): MentionTagWrapper document swap and selection timing for @/#/$ triggers#2720
dev-chetan wants to merge 52 commits into
singerdmx:masterfrom
dev-chetan:master

Conversation

@dev-chetan
Copy link
Copy Markdown

@dev-chetan dev-chetan commented Mar 22, 2026

Description

Describe what this PR does. If modifying behavior, explain the current and new behavior, along with the motivation.

Related Issues

Type of Change

  • Feature: New functionality without breaking existing features.
  • 🛠️ Bug fix: Resolves an issue without altering current behavior.
  • 🧹 Refactor: Code reorganization, no behavior change.
  • Breaking: Alters existing functionality and requires updates.
  • 🧪 Tests: New or modified tests
  • 📝 Documentation: Updates or additions to documentation.
  • 🗑️ Chore: Routine tasks, or maintenance.
  • Build configuration change: Build/configuration changes.

@dev-chetan
Copy link
Copy Markdown
Author

Hi 👋
I’ve opened this PR and noticed that workflows are awaiting approval.
Could you please approve the workflows so CI checks can run?
Thank you!

Copy link
Copy Markdown
Author

@dev-chetan dev-chetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix mention/tag style leaks and suggestion state issues

  • Prevent stale async search results from replacing newer suggestions
  • Refresh mention/tag config when wrapper inputs change
  • Support multi-word @ and $ queries without hiding overlay early
  • Reuse KeyboardListener FocusNode instead of recreating it
  • Prevent token styles from leaking into text typed after selected tags
  • Optimize post-selection cleanup to avoid unnecessary formatting work

@dev-chetan
Copy link
Copy Markdown
Author

Hi, I’ve completed all requested tasks and pushed the latest fixes. Could you please review and approve when you get a chance?

Copy link
Copy Markdown
Author

@dev-chetan dev-chetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix empty mention/tag suggestions rendering in read-only config

Copy link
Copy Markdown
Author

@dev-chetan dev-chetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes and bug fixed

Copy link
Copy Markdown
Author

@dev-chetan dev-chetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

Copy link
Copy Markdown
Author

@dev-chetan dev-chetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some change

Copy link
Copy Markdown
Author

@dev-chetan dev-chetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes in json

Copy link
Copy Markdown
Author

@dev-chetan dev-chetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes

@dev-chetan
Copy link
Copy Markdown
Author

Hi, workflows for my PR #2720 are awaiting approval.
Could you please approve the workflows to run?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant