Remove dependency on the deprecated lodash.get #254
Conversation
lib/create-matcher.js
Outdated
| if ( | ||
| actual === undefined || | ||
| actual === null || | ||
| get(actual, property) === undefined | ||
| getNestedProperty(actual, property) === undefined |
There was a problem hiding this comment.
can't we just use ?. operator, ie actual?.property === undefined ?
There was a problem hiding this comment.
Thanks for bringing it up. I updated the PR to use ?. instead of .reduce and a helper function. We still need slightly more than just a direct substitution of .get() with ?. though because ?. handles individual properties and hasNested function needs to handle nested paths which are not single properties.
To handle nested paths, the regex is breaking the property string into its individual components and removes empty values. The loop traverses the object, moving one level deeper for each part of the path so we can safely access the next property (part) of the current object (current = current?.[part]). This handles cases where any intermediate property might be undefined or null. If current becomes undefined at any point we know the path doesn't exist, so we can immediately return false. After the loop is finished then the value of current is the value we want to get.
YasharF
force-pushed
the
main
branch
2 times, most recently
from
9e69aa1 to
bebdcd2
Compare
We need slightly more than a direct substitution of `.get()` with `?.` because `?.` handles individual properties and hasNested function needs to handle nested paths which are not single properties. To handle nested paths, the regex is breaking the property string into its individual components and removes empty values. The loop traverses the object, moving one level deeper for each part of the path so we can safely access the next property (part) of the current object (`current = current?.[part]`). This handles cases where any intermediate property might be `undefined` or `null`. If `current` becomes `undefined` at any point we know the path doesn't exist, so we can immediately return `false`. After the loop is finished then the value of `current` is the value we want to get.
lodash.get has been deprecated and consumers of samsam get the following deprecation warning during their npm install:
Background
Fixes issue: #253
How to verify
npm cinpm run test