Remove the legacy gpu_processing execution path#1055
Draft
mbrobbel wants to merge 1 commit into
Draft
Conversation
Delete the dead legacy Sirius engine (src/legacy/, src/include/legacy/) and everything that referenced it, keeping only Super Sirius. - Drop the ENABLE_LEGACY_SIRIUS build option and the SIRIUS_ENABLE_LEGACY code paths: legacy CMake wiring, the legacy-release Makefile target and CMake preset, and the variant: legacy CI matrix (now single-valued). - Remove the gpu_processing / gpu_buffer_init table functions and the now-dead use_pin_memory / use_pin_memory_for_caching config flags whose only consumer was the legacy buffer manager. - Delete legacy benchmark/SQL scripts, the ClickBench harness, the legacy SQLLogic tests, the cpu_cache test, and the orphaned legacy-coupled tests, reconciling test/cpp/orphan_test_allowlist.txt. - Strip the SIRIUS_ENABLE_LEGACY blocks from the shared test utils and scrub docs/comments that named the removed path. Verified: full release build, sirius_unittest (all cases pass on GPU), and pre-commit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mbrobbel
marked this pull request as ready for review
July 2, 2026 12:01
Collaborator
|
I dont think we can do this yet as our ClickBench #1 result is using this, and if someone wants to reproduce it it will break if we do this |
mbrobbel
marked this pull request as draft
July 2, 2026 15:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dead legacy Sirius execution path (the
gpu_processingengine) entirely, keeping only Super Sirius. Legacy was already gated OFF by default (ENABLE_LEGACY_SIRIUS/SIRIUS_ENABLE_LEGACY), so this deletes code and support that no longer runs.Removed
src/legacy/andsrc/include/legacy/(thegpu_processing/gpu_buffer_initengine, buffer manager, legacy expression executor, plan generator, operators, CUDA kernels), plus every#ifdef SIRIUS_ENABLE_LEGACYblock insirius_extension.{cpp,hpp}.ENABLE_LEGACY_SIRIUSoption andSIRIUS_LEGACY_*CMake wiring, thelegacy-releaseMakefile target and CMake preset, and thevariant: legacyCI build (the now single-valuedvariantmatrix dimension is dropped).use_pin_memory/use_pin_memory_for_cachingSET options andUSE_PIN_MEM_FOR_*flags, whose only consumer was the legacy buffer manager.cpu_cachetest, orphaned legacy-coupled C++ tests (withorphan_test_allowlist.txtreconciled),docs/gpu_processing.md, and stale doc/comment references.Behavior change
The
gpu_processingandgpu_buffer_inittable functions and theuse_pin_memory*SET options no longer exist —gpu_execution(transparent SQL interception) is the sole entry point.Validation
sirius_unittest) clean.sirius_unittest: all 1469 cases pass on GPU.pre-commit run -agreen, including thecheck-orphan-testsgate.Not included (possible follow-ups)
parquet_scan_taskreferences left by an earlier scan-manager cleanup — unrelated to this removal.bugfix.testregression cases, if that coverage is still wanted.🤖 Generated with Claude Code