fix(starrocks): serialize result batches into a growable buffer#1106
Merged
Conversation
Result batches can be arbitrarily large; the fixed 64 KiB thrift channel truncated anything bigger, surfacing as a transport error on the fetch_data path. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 7, 2026
mbrobbel
marked this pull request as ready for review
July 8, 2026 07:24
aocsa
approved these changes
Jul 14, 2026
aocsa
left a comment
aocsa
left a comment
Contributor
There was a problem hiding this comment.
One small non-blocking suggestion: this change is easiest to regress accidentally during a future refactor because the buffer size is no longer explicit. Would you mind adding a test that serializes a TResultBatch larger than 64 KiB and asserts the output length exceeds that limit? That would lock in the growable-buffer behavior.
kevkrist
pushed a commit
to kevkrist/sirius
that referenced
this pull request
Jul 15, 2026
…-db#1107) Encode decimal128, date32, and microsecond-timestamp result columns (plus large/view string arrays) as MySQL text on the `fetch_data` path. ## Stack All based on `dev`, so each diff includes the levels below it until they merge (review commits, or the last commit, for the per-level change): 1. sirius-db#1106 2. sirius-db#1107 ⬅️ this PR 3. sirius-db#1108 4. sirius-db#1109 5. sirius-db#1110 6. sirius-db#1111 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result batches can be arbitrarily large; the fixed 64 KiB thrift channel truncated them, surfacing as a transport error at
fetch_data. Serialize into a plain growable buffer instead.Stack
All based on
dev, so each diff includes the levels below it until they merge (review commits, or the last commit, for the per-level change):🤖 Generated with Claude Code