Skip to content

Conversation

@lyjy-kq
Copy link

@lyjy-kq lyjy-kq commented Oct 24, 2025

If you are submitting a new bazaar package for the first time, please confirm the following information.

  • The repository is public
  • Include the appropriate open source license file LICENSE
  • Does not involve infringing content, such as non-commercial font files

@github-actions
Copy link

Pull Request Check Report

Add 0 Icon Repo

Add 1 Plugin Repo

lyjy-kq/siyuan-plugin-lyjy-code-block


Add 0 Template Repo

Add 0 Theme Repo

Add 0 Widget Repo

@TCOTC TCOTC changed the title Add new plugin entry to plugins.json Add lyjy-kq/siyuan-plugin-lyjy-code-block Oct 24, 2025
@TCOTC TCOTC self-requested a review October 24, 2025 16:32
@TCOTC
Copy link
Collaborator

TCOTC commented Oct 24, 2025

  • 更新 LICENSE 文件版权信息

  • README 中的“使用 IBM Plex Mono 字体提升代码块可读性”描述是否不太对?字体只应用于代码块语言元素

  • README 中的“自定义大纲样式”描述是否不太对?代码中并没有相关功能

  • package.zip 打包了多余的 ico.png 和 pre.png 文件

  • index.ts 缺少 onunload() 方法(移除插件添加的元素、监听器等)

  • index.ts 缺少 uninstall() 方法(逻辑应与 onunload 相同,并且增加删除插件配置文件的逻辑)

  • 在暗黑模式中的配色太明亮,需修改 index.scss(利用 [data-theme-mode] 属性):

    image
  • 修改 plugin.json:

     {
       "name": "siyuan-plugin-lyjy-code-block",
       "author": "lyjy",
       "url": "https://github.com/lyjy-kq/siyuan-plugin-lyjy-code-block",
       "version": "1.1.0",
       "minAppVersion": "3.2.1",
       "backends": [ // 改为 ["all"]
         "windows",
         "linux",
         "darwin",
         "ios",
         "android",
         "harmony",
         "docker"
       ],
       "frontends": [ // 改为 ["all"]
         "desktop",
         "mobile",
         "browser-desktop",
         "browser-mobile",
         "desktop-window"
       ],
       // 缺少 "disabledInPublish": true,
       "displayName": {
         "en_US": "LYJY Code Block Enhancer", // "en_US" 字段名改为 "default"
         "zh_CN": "LYJY 代码块增强"
       },
       "description": {
         "en_US": "Enhances SiYuan code blocks with language detection, customizable regex patterns, and modern styling.", // "en_US" 字段名改为 "default"
         "zh_CN": "为思源笔记代码块提供语言检测、自定义正则规则和现代样式增强。"
       },
       "readme": {
         "en_US": "README.md", // "en_US" 字段名改为 "default"
         "zh_CN": "README_zh_CN.md"
       },
       "funding": {
         "custom": [
           "https://github.com/lyjy-kq"
         ]
       },
       "keywords": [ // 都是冗余的关键词,应删除
         "code block",
         "language detection",
         "outline styling",
         "插件",
         "代码块",
         "语言检测",
         "大纲样式"
       ]
     }

修改完毕后重新打包发布版本,然后在下方回复我

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants