Skip to content

Conversation

@yunseo904
Copy link

@yunseo904 yunseo904 commented Jan 16, 2026

Description

  • contest main page에서 작은 배너와 대회 테이블 사이 간격을 디자인 시안에 맞게 조정했습니다.
  • registered 체크 아이콘이 각 row의 위아래 정중앙에 위치하도록 셀/아이콘 정렬을 보정했습니다.

<수정 전 (현재 홈페이지 화면)>
image

<수정 후>
image

Additional context

closes TAS-2362

@skkuding-bot
Copy link

skkuding-bot bot commented Jan 16, 2026

Syncing Preview App Succeeded

Application: frontend
Revision: f36787fe98119033d9f8740a5900012e5949ff71
Health Status: Healthy

Open Preview | View in Argo CD

@yunseo904 yunseo904 self-assigned this Jan 16, 2026
@notion-task-integration
Copy link

notion-task-integration bot commented Jan 16, 2026

@yunseo904 yunseo904 requested a review from Clover229 January 16, 2026 07:48
Copy link
Contributor

@Clover229 Clover229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 전과 수정 후의 사진을 pr description에 붙여주세요! 자세한 설명이 필요합니다~

return (
<>
<div className="mb-11 flex justify-between">
<div className="flex flex-col gap-14">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gap 14가 맞나요? 확인해주세요~ 피그마에서는 다르게 보여요.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피그마 다시 확인해보니까 gap이 32px로 되어있어서 gap 8로 수정했습니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image 41아닌가요?!

row.original.isRegistered && (
<div className="flex items-center justify-center">
<Image src={checkIcon} alt="check" height={24} />
<Image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

체크 아이콘이 왼쪽으로 치우친 것 같아요~ 확인해주세요.

setFilteredData(table.getFilteredRowModel().rows.map((row) => row.original))
}, [table.getFilteredRowModel().rows, setFilteredData])
setFilteredData(filteredRows.map((row) => row.original))
}, [filteredRows, setFilteredData])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작은 리팩토링 너무 좋습니다 😆

@yunseo904 yunseo904 force-pushed the t2362-contest-main-page-design branch from f36787f to 443b175 Compare January 16, 2026 10:38
@skkuding-bot
Copy link

skkuding-bot bot commented Jan 16, 2026

Syncing Preview App Succeeded

Application: frontend
Revision: 443b1754dc8e2ec2893393c628ba1417744b1cb1
Health Status: Healthy

Open Preview | View in Argo CD

…n alignment

contest main page에서 작은 배너와 대회 테이블 사이 간격을 디자인 시안에 맞게 조정함.

registered 체크 아이콘이 각 row의 위아래 정중앙에 위치하도록 셀/아이콘 정렬을 보정함.
@yunseo904 yunseo904 force-pushed the t2362-contest-main-page-design branch from 443b175 to 552a4e5 Compare January 16, 2026 10:47
@skkuding-bot
Copy link

skkuding-bot bot commented Jan 16, 2026

Syncing Preview App Succeeded

Application: frontend
Revision: 552a4e51d64c15f667f5a79797998d6fbb19c827
Health Status: Healthy

Open Preview | View in Argo CD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants