-
Notifications
You must be signed in to change notification settings - Fork 15
chore(fe): adjust contest main page layout spacing and registered icon alignment #3354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Syncing Preview App Succeeded Application: |
Clover229
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정 전과 수정 후의 사진을 pr description에 붙여주세요! 자세한 설명이 필요합니다~
| return ( | ||
| <> | ||
| <div className="mb-11 flex justify-between"> | ||
| <div className="flex flex-col gap-14"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gap 14가 맞나요? 확인해주세요~ 피그마에서는 다르게 보여요.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
피그마 다시 확인해보니까 gap이 32px로 되어있어서 gap 8로 수정했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| row.original.isRegistered && ( | ||
| <div className="flex items-center justify-center"> | ||
| <Image src={checkIcon} alt="check" height={24} /> | ||
| <Image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
체크 아이콘이 왼쪽으로 치우친 것 같아요~ 확인해주세요.
| setFilteredData(table.getFilteredRowModel().rows.map((row) => row.original)) | ||
| }, [table.getFilteredRowModel().rows, setFilteredData]) | ||
| setFilteredData(filteredRows.map((row) => row.original)) | ||
| }, [filteredRows, setFilteredData]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
작은 리팩토링 너무 좋습니다 😆
f36787f to
443b175
Compare
|
✅ Syncing Preview App Succeeded Application: |
…n alignment contest main page에서 작은 배너와 대회 테이블 사이 간격을 디자인 시안에 맞게 조정함. registered 체크 아이콘이 각 row의 위아래 정중앙에 위치하도록 셀/아이콘 정렬을 보정함.
443b175 to
552a4e5
Compare
|
✅ Syncing Preview App Succeeded Application: |

Description
<수정 전 (현재 홈페이지 화면)>

<수정 후>

Additional context
closes TAS-2362