-
Notifications
You must be signed in to change notification settings - Fork 15
docs(be): add JSDoc into NotificationService with Refactoring #3364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nhjbest22
wants to merge
14
commits into
main
Choose a base branch
from
t2446-add-JSDoc-into-notification-service
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+96
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onRecord handling
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
|
✅ Syncing Preview App Succeeded Application: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NotificationService의 함수들의 역할을 명확히하기 위해 JSDoc을 추가했습니다.Additional context
추가적인 리팩토링을 진행하였습니다.
codedang/apps/backend/apps/admin/src/notification/notification.service.ts
Lines 196 to 212 in 705aa73
기존에는 위 코드와 같이 notification 엔티티를 생성한 후 notificationRecord 엔티티를 별도로 생성하도록 되어 있었습니다.
2번의 쿼리 호출이 비효율적인 것 같아 다음과 같이 1번의 쿼리 호출로 모든 엔티티가 생성되도록 변경하였습니다.
codedang/apps/backend/apps/admin/src/notification/notification.service.ts
Lines 246 to 258 in bc5d83e
Closes TAS-2446
Before submitting the PR, please make sure you do the following
fixes #123).