Handle blank addresses in CC and BCC lists, as these cause a Sendgrid error #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sklarsa
requested changes
Mar 26, 2025
| @@ -310,11 +310,13 @@ def _build_sg_personalization( | |||
|
|
|||
| if not personalization.ccs: | |||
| for addr in msg.cc: | |||
| personalization.add_cc(Email(*self._parse_email_address(addr))) | |||
| if addr: | |||
There was a problem hiding this comment.
Can we add a warning log if addr == ""?
|
|
||
| if not personalization.bccs: | ||
| for addr in msg.bcc: | ||
| personalization.add_bcc(Email(*self._parse_email_address(addr))) | ||
| if addr: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accidentally sending blank addresses in the lists for CC or BCC, Sendgrid's API will raise an exception. Therefore, we can ignore them when constructing the email object.
I've omitted the same check from the TO list, as we probably want an exception raised here since something more serious is wrong.