First pass at a stubzones bugfix #310
Open
kdima wants to merge 2 commits into
Open
Conversation
Author
|
This is the first pass if the implementation looks reasonable I will add same logics to etcd3 backend. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue.
Say you have 2 stubzones registered in etcd the following way:
Current implementation will consider these records duplicate and one of the stubzones will not be available.
To avoid this when we are looking up stubzone records we keep track of the subdomain in this case
stubzone1.a.othertest.comandstubzone2.othertest.comand dedup records only inside the same subdomian.I am not sure if this should be behind the flag
stubor this can work as a general implementation.