-
Notifications
You must be signed in to change notification settings - Fork 847
Add yum check for rclone installation #7740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add yum check for rclone installation #7740
Conversation
kevinmingtarja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @EricBryann!
Let's add a smoke test on AWS for this :)
Some pointers:
- rclone is needed only with MOUNT_CACHED mode (or on arm64 arch),
- So you can copy test_kubernetes_storage_mounts_cached as a starting point
- Let's test with two different AMIs that are different linux distros, one with dpkg, the other with yum. We can take ubuntu and amazon linux 2023 for example
7598e34 to
40c1c3f
Compare
…skypilot into check-bin-for-rclone-install
|
/smoke-test -k storage_mounts_cached --aws |
…o check-bin-for-rclone-install
|
|
|
/smoke-test -k storage --aws |
|
/smoke-test -k test_aws_storage_mounts_cached --aws |
|
/smoke-test -k test_aws_storage_mounts_cached |
|
The two test failures are unrelated, fixed by #7818. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution @EricBryann ! Just left one nit.
| 'ami-0f5fcdfbd140e4ab7', # dpkg | ||
| 'ami-0a5a5b7e2278263e5' # yum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Could we keep the aws ec2 describe-images ... commands comment that you had in the prev commit here for future reference.
|
/smoke-test -k storage --nebius |
|
/smoke-test -k storage --azure |
PR to fix #6567
When
dpkgruns into an error, the code defaults toyum, and some don't haveyuminstalled, resulting insudo: yum: command not foundThis PR checks for existence of
yumbeforercloneinstallTested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)