Remove Loki logging integration from benchmark module - #117
Merged
Conversation
Loki was confined to sliceworkz-eventstore-benchmark: a compile-scope com.github.loki4j:loki-logback-appender and an appender block in its logback.xml. The appender was already commented out of the root logger, and logback does not process an appender nothing references — startup reports "Appender named [LOKI] not referenced. Skipping further processing." — so nothing was ever sent, no class loaded and no thread started. The block's comment also pointed at a `docker compose up` for a compose file this repository no longer contains. What it still cost: 120KB of dead classes shaded into the benchmark's executable jar, and a dependency Dependabot keeps proposing upgrades for. No published artifact is affected. The benchmark module sets maven.deploy.skip, and the dependency was declared there only, so no released module ever carried it and no consumer's classpath changes. Verified: the module builds, the shaded jar contains no com/github/loki4j entries (16,438,596 -> 16,316,662 bytes), the dependency tree no longer mentions loki, and the logback config parses with the root logger still attached to CONSOLE. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NKMCrqqcnhpcCvXJbFEw1e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the Loki4j logging appender configuration and dependency from the eventstore-benchmark module. This simplifies the logging setup by removing the optional distributed logging capability that was not actively used.
Changes
loki-logback.versionproperty definitionloki-logback-appenderdependencyDetails
The benchmark module now uses only the console appender for logging, reducing external dependencies and simplifying the logging configuration. The Loki integration was previously optional (commented out) and required Docker Compose to be running, making it an unnecessary dependency for the core benchmark functionality.
https://claude.ai/code/session_01NKMCrqqcnhpcCvXJbFEw1e