Repository navigation
Strip settings out of Visual Editor - #12891
Merged
LeonMatthes merged 2 commits intoAug 13, 2026
Merged
Conversation
The feature is being upstreamed separately in slint-ui#12111, so it does not belong in the visual editor branch. Drop it here to keep this branch's eventual squashed commit free of it; it comes back from master once the PR lands. This removes the settings store, the PreviewUserSettings / EditorUserSettings types, their protocol messages and the UI wiring, and restores RequestState to its plain file-list form. The editor settings on top of it (always-on-top for the editor window) go with it and can be re-added later.
The issue was caused by a compiler bug, which has since been fixed in master by PR slint-ui#12155 .
tronical
approved these changes
Aug 13, 2026
LeonMatthes
force-pushed
the
visual-editor-stripped
branch
from
August 13, 2026 12:28
8071ee3 to
40f4d1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The settings were not really used by the Visual Editor and have now been moved into a separate PR.