Conversation
thodges-gh
requested review from
a team,
andrejrakic,
pappas999 and
zeuslawyer
as code owners
|
👋 thodges-gh, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
zeuslawyer
left a comment
zeuslawyer
left a comment
There was a problem hiding this comment.
Note small comment. LGTM - thanks for tidying!
zeuslawyer
left a comment
zeuslawyer
left a comment
There was a problem hiding this comment.
LGTM with one observation
| fetch-depth: 0 | ||
|
|
||
| - name: Setup pnpm | ||
| uses: pnpm/action-setup@fe02b34f77f8bc703788d5817da081398fad5dd2 # v4.0.0 |
There was a problem hiding this comment.
Recently saw another thread where pnpm treats module imports (with version numbers) from contracts npm package differently from how npm does. Consider whether its worth using npm instead because that is the wider "standard" since this is a package that is used prebuilt and distributed rather than just a repo?
There was a problem hiding this comment.
I'll convert to NPM in a future PR.
2 participants
No description provided.