Conversation
thodges-gh
requested review from
a team,
andrejrakic,
pappas999 and
zeuslawyer
as code owners
zeuslawyer
reviewed
Sep 9, 2025
| if (!chain) throw new Error('Chain is required to adapt an ethers Provider to a viem PublicClient') | ||
| return ethersProviderToPublicClient(client, chain) | ||
| } | ||
| if (isEthersSigner(client)) { |
Contributor
There was a problem hiding this comment.
since this method toViemPublicClient is only called in other methods after isEthersProvider() is asserted in those methods, isnt this just doubling up. If this function is invoked, then isEthersProvider() is always expected to be false?
…at accepts Ethers.js signer. Update example nextjs app's routes to show wagmi use and etherjs use with ccipClient. Update dependencies - Updated `@chainlink/ccip-js` dependency in `examples/nextjs/package.json` to use workspace reference. This means it will use local built version of ccip-js package rather than published version. But will use published version when it itself is publised to npmjs. - Added new Ethers.js components and page routes to show the CCIP JS Package API. - Updated `pnpm-lock.yaml` to reflect new dependencies and versions. - Removed outdated Babel dependencies and updated node types across various packages.
…rrors. Refactor Ethers.js adapter to use custom type definitions for contract calls, transactions, receipts, and logs. This change eliminates 'as any' casts, improving type safety and code clarity. Additionally, update integration tests to reflect these changes and ensure compatibility with the new type definitions.
Zp patch ethers impl
…tests for ccip-js.
Contributor
Author
|
Implemented via #41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.