Extend cldf timelock converter logic for TON #628

huangzhen1997 · 2025-12-09T22:54:21Z

Adding TON timelock converter support. Note the TON support for executor override is also added here, but there's another PR for supporting the migration to MCMS-Tools repo: https://github.com/smartcontractkit/mcms-tools/pull/261

Need to add test coverage

changeset-bot · 2025-12-09T22:54:24Z

⚠️ No Changeset found

Latest commit: 62b9727

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-12-09T22:54:32Z

👋 huangzhen1997, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copilot

Pull request overview

This PR extends the CLDF (Chainlink Deployments Framework) proposal conversion logic to support the TON (The Open Network) blockchain. The changes enable TON chain integration by adding necessary converters, executors, and inspectors while also updating various dependencies.

Key changes:

Add TON support to MCMS v2 CLI with timelock converter, executor, and inspector implementations
Introduce TxOps struct to encapsulate TON transaction operation configuration
Update multiple dependencies including Go version, chainlink-ccip, mcms, and tonutils-go

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
go.mod	Updates Go version to 1.25.3 and upgrades multiple dependencies including TON-related libraries
engine/cld/legacy/cli/mcmsv2/mcms_v2.go	Adds TON chain family support with converter, executor, and inspector implementations; refactors variable naming
chain/ton/ton_chain.go	Introduces TxOps struct to hold wallet and amount configuration for transactions
chain/ton/provider/rpc_provider.go	Initializes TxOps with default transaction amount in RPC provider
chain/ton/provider/ctf_provider_test.go	Updates test to verify TxOps instead of Wallet field
chain/ton/provider/ctf_provider.go	Initializes TxOps with default amount; fixes wallet method call to use WalletAddress()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

chain/ton/provider/ctf_provider.go

…rt-ton-timelock-converter

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-12T04:26:13Z

chain/ton/provider/ctf_provider.go

 		Client:        nodeClient,
-		Wallet:        tonWallet,
-		WalletAddress: tonWallet.Address(),
+		WalletAddress: tonWallet.WalletAddress(),


The change from tonWallet.Address() to tonWallet.WalletAddress() lacks test coverage. The existing test in ctf_provider_test.go only checks that WalletAddress is not empty but doesn't verify the correct method is being called or that the address value is as expected.

@copilot This is not true, it's tested in rpc_provider_test.go line 276

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

…rt-ton-timelock-converter

…lock-converter' of github.com:smartcontractkit/chainlink-deployments-framework into NONEVM-3069/extend-cldf-proposal-logic-support-ton-timelock-converter

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-27T04:26:19Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

 					return nil, fmt.Errorf("error creating Sui timelock converter: %w", err)
 				}
+			case chainsel.FamilyTon:
+				converter = ton.NewTimelockConverter(tlb.MustFromTON(defaultTONExecutorAmount))


The TON timelock converter initialization lacks test coverage. Consider adding a test case similar to the existing Sui test case at line 1136-1138 to verify the converter is created correctly for TON chains.

Copilot · 2026-01-27T04:26:19Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

+			Amount:  tlb.MustFromTON(defaultTONExecutorAmount),
+		}
+
+		return ton.NewExecutor(opts)


The TON executor creation in getExecutorWithChainOverride lacks test coverage. Add test cases to verify the executor is created correctly with the expected options, including the Amount field set to defaultTONExecutorAmount.

Copilot · 2026-01-27T04:26:19Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

+			Amount: tlb.MustFromTON(defaultTONExecutorAmount),
+		}
+
+		return ton.NewTimelockExecutor(opts)


The TON timelock executor creation in getTimelockExecutorWithChainOverride lacks test coverage. Add test cases to verify the timelock executor is created correctly with the expected options, similar to other chain family test cases.

Copilot · 2026-01-27T04:26:19Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

+		chain := cfg.blockchains.TonChains()[cfg.chainSelector]
+		inspector = ton.NewInspector(chain.Client)


Variable 'chain' should be renamed to 'c' for consistency with the naming pattern used in the same function for other chain families (lines 1535, 1539, 1542, 1545).

Suggested change

chain := cfg.blockchains.TonChains()[cfg.chainSelector]

inspector = ton.NewInspector(chain.Client)

c := cfg.blockchains.TonChains()[cfg.chainSelector]

inspector = ton.NewInspector(c.Client)

Copilot · 2026-01-27T04:26:19Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

 		}
+	case chainsel.FamilyTon:
+		chain := cfg.blockchains.TonChains()[cfg.chainSelector]
+		inspector = ton.NewInspector(chain.Client)


The TON inspector creation in getInspectorFromChainSelector lacks test coverage. Add test cases to verify the inspector is created correctly for TON chains.

gustavogama-cll

re-approving mcms changes

krebernisak · 2026-01-27T10:27:51Z

chain/ton/provider/rpc_provider.go

+}
+
+// buildChain creates a ton.Chain with the given parameters.
+func buildChain(selector uint64, api *tonlib.APIClient, tonWallet *wallet.Wallet, httpURL string) *ton.Chain {


Not sure what's the purpose of this method, which just instantiates the type vs just doing it without the method? Then we also have a Test_buildChain test for this method? Seems we could do without.

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

…rt-ton-timelock-converter

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-29T17:12:42Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

 	defaultProposalValidity = 72 * time.Hour
+
+	// defaultTONExecutorAmount is the default amount of TON for MCMS/Timelock executor transactions.
+	// This is a static estimate that should be sufficient for most operations.


The comment describes this as a 'static estimate' but doesn't explain why 0.1 TON was chosen or what factors influence whether this amount is sufficient. Consider adding context about what operations this covers and approximate cost considerations.

Suggested change

// This is a static estimate that should be sufficient for most operations.

// This is a conservative static estimate intended to cover the gas and storage fees for a

// typical MCMS/Timelock executor flow on TON (e.g. submitting and executing a proposal with

// a small to medium number of actions) under current mainnet fee conditions, with an extra

// safety buffer. The 0.1 TON value was chosen based on observed costs for common operations

// plus headroom to account for moderate message size growth and fee fluctuations.

//

// IMPORTANT: This may be insufficient for unusually large/complex proposals, for networks

// or environments with significantly higher fees, or if TON fee dynamics change over time.

// Operators who routinely submit high-complexity proposals should consider overriding this

// default with a higher value until a dynamic gas estimation mechanism is available.

//

Copilot · 2026-01-29T17:12:43Z

engine/cld/legacy/cli/mcmsv2/mcms_v2.go

+	case chainsel.FamilyTon:
+		encoder, ok := encoder.(*ton.Encoder)
+		if !ok {
+			return nil, fmt.Errorf("invalid encoder type for TON chain %d: expected *ton.Encoder, got %T", chainSelector, encoder)


The error message for TON encoder type validation is more detailed than the equivalent error messages for EVM (line 1451), Solana (line 1460), Aptos (line 1468), and Sui (line 1481) chains, which only say 'invalid encoder type: %T'. Consider making error messages consistent across all chain families.

Suggested change

return nil, fmt.Errorf("invalid encoder type for TON chain %d: expected *ton.Encoder, got %T", chainSelector, encoder)

return nil, fmt.Errorf("invalid encoder type: %T", encoder)

Copilot · 2026-01-29T17:12:43Z

chain/ton/provider/rpc_provider_test.go

+	p := &RPCChainProvider{
+		selector: 123,
+		config: RPCChainProviderConfig{
+			HTTPURL:           "", // invalid - missing URL


The comment says 'invalid - missing URL' but an empty string is technically a valid Go string value. Consider clarifying that this is testing validation logic for an empty/missing URL configuration.

Suggested change

HTTPURL: "", // invalid - missing URL

HTTPURL: "", // invalid: empty URL to test validation of missing/empty configuration

cl-sonarqube-production · 2026-01-29T17:21:24Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

extend cldf proposal conversion logic

3261478

huangzhen1997 requested a review from a team as a code owner December 9, 2025 22:54

Copilot AI review requested due to automatic review settings December 9, 2025 22:54

Copilot AI reviewed Dec 9, 2025

View reviewed changes

engine/cld/legacy/cli/mcmsv2/mcms_v2.go Outdated Show resolved Hide resolved

chain/ton/provider/ctf_provider.go Outdated Show resolved Hide resolved

huangzhen1997 commented Dec 9, 2025

View reviewed changes

chain/ton/provider/ctf_provider.go Outdated Show resolved Hide resolved

huangzhen1997 marked this pull request as draft December 9, 2025 23:04

huangzhen1997 changed the title ~~Extend cldf proposal conversion logic for TON~~ Extend cldf timelock converter logic for TON Dec 9, 2025

huangzhen1997 requested review from jadepark-dev and krebernisak December 9, 2025 23:05

fix goimport

ce292f9

jadepark-dev reviewed Dec 10, 2025

View reviewed changes

chain/ton/provider/ctf_provider.go Outdated Show resolved Hide resolved

krebernisak reviewed Dec 10, 2025

View reviewed changes

chain/ton/provider/ctf_provider.go Outdated Show resolved Hide resolved

chain/ton/provider/ctf_provider.go Outdated Show resolved Hide resolved

huangzhen1997 added 5 commits December 10, 2025 10:18

rm redundant wallet funds

76f7941

remove unused fundwallet func

6b03e06

add test coverage

bb6622b

update test

564f880

Merge branch 'main' into NONEVM-3069/extend-cldf-proposal-logic-suppo…

fa6aa6c

…rt-ton-timelock-converter

huangzhen1997 requested review from Copilot, jadepark-dev and krebernisak December 12, 2025 04:25

Copilot AI reviewed Dec 12, 2025

View reviewed changes

update

580e5c7

huangzhen1997 marked this pull request as ready for review December 12, 2025 04:33

Copilot AI review requested due to automatic review settings December 12, 2025 04:33

Copilot AI reviewed Dec 12, 2025

View reviewed changes

engine/cld/legacy/cli/mcmsv2/mcms_v2.go Outdated Show resolved Hide resolved

engine/cld/legacy/cli/mcmsv2/mcms_v2.go Outdated Show resolved Hide resolved

engine/cld/legacy/cli/mcmsv2/mcms_v2.go Show resolved Hide resolved

huangzhen1997 requested a review from ecPablo December 12, 2025 15:23

huangzhen1997 added 2 commits December 15, 2025 20:30

bump version

d139579

bump mcms version

e0493eb

huangzhen1997 added 3 commits January 26, 2026 22:22

Merge branch 'main' into NONEVM-3069/extend-cldf-proposal-logic-suppo…

022e0df

…rt-ton-timelock-converter

minor

075de4e

Merge branch 'NONEVM-3069/extend-cldf-proposal-logic-support-ton-time…

e5efbd0

…lock-converter' of github.com:smartcontractkit/chainlink-deployments-framework into NONEVM-3069/extend-cldf-proposal-logic-support-ton-timelock-converter

huangzhen1997 requested review from Copilot, gustavogama-cll and krebernisak January 27, 2026 04:25

Copilot AI reviewed Jan 27, 2026

View reviewed changes

gustavogama-cll previously approved these changes Jan 27, 2026

View reviewed changes

krebernisak previously approved these changes Jan 27, 2026

View reviewed changes

rm buildChain

b25e6bc

huangzhen1997 dismissed stale reviews from krebernisak and gustavogama-cll via b25e6bc January 27, 2026 16:13

fix lint

42d488c

Copilot AI review requested due to automatic review settings January 27, 2026 18:09

Copilot AI reviewed Jan 27, 2026

View reviewed changes

engine/cld/legacy/cli/mcmsv2/mcms_v2.go Show resolved Hide resolved

engine/cld/legacy/cli/mcmsv2/mcms_v2.go Show resolved Hide resolved

Merge branch 'main' into NONEVM-3069/extend-cldf-proposal-logic-suppo…

ced4bfd

…rt-ton-timelock-converter

huangzhen1997 requested review from gustavogama-cll and krebernisak and removed request for krebernisak January 27, 2026 18:16

Merge branch 'main' into NONEVM-3069/extend-cldf-proposal-logic-suppo…

62b9727

…rt-ton-timelock-converter

Copilot AI review requested due to automatic review settings January 29, 2026 17:11

Copilot AI reviewed Jan 29, 2026

View reviewed changes

ecPablo approved these changes Jan 30, 2026

View reviewed changes

krebernisak approved these changes Jan 30, 2026

View reviewed changes

huangzhen1997 added this pull request to the merge queue Jan 30, 2026

Merged via the queue into main with commit 7f30604 Jan 30, 2026
16 checks passed

huangzhen1997 deleted the NONEVM-3069/extend-cldf-proposal-logic-support-ton-timelock-converter branch January 30, 2026 17:12

		chain := cfg.blockchains.TonChains()[cfg.chainSelector]
		inspector = ton.NewInspector(chain.Client)

-	// This is a static estimate that should be sufficient for most operations.
+	// This is a conservative static estimate intended to cover the gas and storage fees for a
+	// typical MCMS/Timelock executor flow on TON (e.g. submitting and executing a proposal with
+	// a small to medium number of actions) under current mainnet fee conditions, with an extra
+	// safety buffer. The 0.1 TON value was chosen based on observed costs for common operations
+	// plus headroom to account for moderate message size growth and fee fluctuations.
+	//
+	// IMPORTANT: This may be insufficient for unusually large/complex proposals, for networks
+	// or environments with significantly higher fees, or if TON fee dynamics change over time.
+	// Operators who routinely submit high-complexity proposals should consider overriding this
+	// default with a higher value until a dynamic gas estimation mechanism is available.
+	//

	return nil, fmt.Errorf("invalid encoder type for TON chain %d: expected *ton.Encoder, got %T", chainSelector, encoder)
	return nil, fmt.Errorf("invalid encoder type: %T", encoder)

	HTTPURL: "", // invalid - missing URL
	HTTPURL: "", // invalid: empty URL to test validation of missing/empty configuration

Extend cldf timelock converter logic for TON #628

Extend cldf timelock converter logic for TON #628

Conversation

huangzhen1997 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

Uh oh!

huangzhen1997 Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

gustavogama-cll left a comment

Choose a reason for hiding this comment

Uh oh!

krebernisak Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

huangzhen1997 commented Dec 9, 2025 •

edited

Loading

changeset-bot bot commented Dec 9, 2025 •

edited

Loading