fix: bind changesets and proposal operations using changeset uuids#919
Merged
gustavogama-cll merged 1 commit intomainfrom Apr 9, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: a076b4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gustavogama-cll
force-pushed
the
ggama/chore/modify-changeset-metadata-added-to-proposal
branch
from
d6b5fec to
559f5aa
Compare
gustavogama-cll
force-pushed
the
ggama/chore/modify-changeset-metadata-added-to-proposal
branch
4 times, most recently
from
a598c21 to
9802665
Compare
gustavogama-cll
force-pushed
the
ggama/chore/modify-changeset-metadata-added-to-proposal
branch
from
9802665 to
24956c3
Compare
graham-chainlink
previously approved these changes
Apr 9, 2026
ecPablo
previously approved these changes
Apr 9, 2026
…y we
relied on the "operation id"s, which had recently been added to the proposal's
operation types. However, that change had to be reverted and the latest
release of mcms no longer contains the operation id attributes.
As an alternative, we now reverse the association by assigning a unique (uu)id
to each changeset, and then add a tag to the operations that were generated by
the changeset:
```json
{
...
"metadata": {
"changesets": [{
"id": "c00e5d67-c275-4389-aded-7d8b151cbd5b",
"name": "my_changeset",
"input": {
"payload": {
"key": "value"
}
}
}]
},
"operations": [{
"chainSelector": 12345678901234567890,
"transactions": [{
"to": "0x02",
"data": "",
"additionalFields": { "value": 0 },
"contractType": "",
"tags": [ "changeset:c00e5d67-c275-4389-aded-7d8b151cbd5b" ]
}]
}]
}
```
This pull-request also applies a couple of change requests from CCIP after
initial tests with the proposal hooks API:
1. return a failure in fork tests and the "mcms hooks" command when a hook
with failure policy set as "abort" returns an error
2. expose an attribute in the ProposalHookEnv indicating whether the
environment is a "forked" one.
---
OPT-467
gustavogama-cll
dismissed stale reviews from ecPablo and graham-chainlink
via
a076b4f
gustavogama-cll
force-pushed
the
ggama/chore/modify-changeset-metadata-added-to-proposal
branch
from
24956c3 to
a076b4f
Compare
Contributor
Author
|
@ecPablo , I pushed a tiny fix identified by Graham. Will need another stamp. |
|
ecPablo
approved these changes
Apr 9, 2026
gustavogama-cll
deleted the
ggama/chore/modify-changeset-metadata-added-to-proposal
branch
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 9, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.94.1 ### Patch Changes - [#919](#919) [`267e083`](267e083) Thanks [@gustavogama-cll](https://github.com/gustavogama-cll)! - fix: use "changeset uuids" to associate proposal operations and changesets --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change how we associate proposal operations and changesets. Previously we relied on the "operation id"s, which had recently been added to the proposal's operation types. However, that change had to be reverted and the latest release of mcms no longer contains the operation id attributes.
As an alternative, we now reverse the association by assigning a unique (uu)id to each changeset, and then add a tag to the operations that were generated by the changeset:
{ ... "metadata": { "changesets": [{ "id": "c00e5d67-c275-4389-aded-7d8b151cbd5b", "name": "my_changeset", "input": { "payload": { "key": "value" } } }] }, "operations": [{ "chainSelector": 12345678901234567890, "transactions": [{ "to": "0x02", "data": "", "additionalFields": { "value": 0 }, "contractType": "", "tags": [ "changeset:c00e5d67-c275-4389-aded-7d8b151cbd5b" ] }] }] }This pull-request also applies a couple of change requests from CCIP after initial tests with the proposal hooks API:
ForkContext) and a corresponding implementation for EVM (EVMForkContext) which allows hooks to identify that they're running inside a "forked environment" and gives them the configuration so that they can directly access it (e.g., the URL of the RPC spawned by the anvil container).OPT-467