NoOpFeeManager interface compatibility #337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
✅ API Diff Results - No breaking changes |
Add constructor parameters and getters required for integration compatibility with official Chainlink Data Streams pattern: - i_linkAddress, i_nativeAddress, i_rewardManager - s_nativeSurcharge() returning 0 Update tests and regenerate geth bindings.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the NoOpFeeManager contract in v0.5.1 to improve interface compatibility with the real FeeManager by adding constructor parameters for link address, native address, and reward manager. This allows integrators to query these addresses before calling getFeeAndReward(), matching the real-world integration pattern.
Changes:
- Added constructor parameters to NoOpFeeManager for storing link, native, and reward manager addresses
- Updated version string from "0.5.0" to "0.5.1"
- Added new test coverage for constructor parameters, native surcharge getter, and integration workflow compatibility
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| contracts/src/v0.8/llo-feeds/v0.5.1/NoOpFeeManager.sol | Added constructor with three address parameters and s_nativeSurcharge() getter for interface compatibility |
| contracts/src/v0.8/llo-feeds/v0.5.1/test/fee-manager/NoOpFeeManager.t.sol | Updated tests to use new constructor and added test coverage for constructor parameters and native surcharge |
| contracts/src/v0.8/llo-feeds/v0.5.1/test/fee-manager/NoOpFeeManager.integration.t.sol | Added comprehensive integration test verifying workflow compatibility between FeeManager and NoOpFeeManager |
| contracts/gas-snapshots/llo-feeds.gas-snapshot | Updated gas consumption measurements for modified tests |
| gethwrappers/llo-feeds/generation/generated-wrapper-dependency-versions-do-not-edit.txt | Updated hash for v0.5.1 NoOpFeeManager wrapper reflecting contract changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce publicly visible parameters to be compatible with existing integration patterns