Skip to content

Fix oldest non-terminal tx db query deadlock #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
silaslenihan wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix oldest non-terminal tx db query deadlock #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions pkg/txmgr/evm_tx_store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1645,10 +1645,15 @@ func (o *evmTxStore) OldestNonTerminalTxAgeSeconds(ctx context.Context, chainID
ctx, cancel = o.stopCh.Ctx(ctx)
defer cancel()
err = o.q.GetContext(ctx, &seconds, `
SELECT GREATEST(0::float8, COALESCE(EXTRACT(EPOCH FROM (NOW() - MIN(created_at))), 0::float8))
FROM evm.txes
WHERE evm_chain_id = $1 AND state NOT IN ('finalized', 'fatal_error')`,
SELECT GREATEST(0::float8, COALESCE(EXTRACT(EPOCH FROM (NOW() - t.created_at)), 0::float8)) AS seconds
FROM evm.txes AS t
WHERE t.evm_chain_id = $1 AND t.state NOT IN ('finalized', 'fatal_error')
ORDER BY t.created_at ASC NULLS LAST
LIMIT 1`,
chainID.String())
if errors.Is(err, sql.ErrNoRows) {
return 0, nil
}
if err != nil {
return 0, fmt.Errorf("failed to OldestNonTerminalTxAgeSeconds: %w", err)
}
Expand Down
5 changes: 4 additions & 1 deletion pkg/txmgr/finalizer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ var (
const (
processHeadTimeout = 10 * time.Minute
attemptsCacheRefreshThreshold = 5
oldestNonTerminalTxAgeMetricQueryTimeout = 5 * time.Second
)

type finalizerTxStore interface {
Expand Down Expand Up @@ -213,7 +214,9 @@ func (f *evmFinalizer) ProcessHead(ctx context.Context, head *types.Head) error
}

func (f *evmFinalizer) observeOldestNonTerminalTxAge(ctx context.Context) {
age, err := f.txStore.OldestNonTerminalTxAgeSeconds(ctx, f.chainID)
ctxObs, cancel := context.WithTimeout(ctx, oldestNonTerminalTxAgeMetricQueryTimeout)
defer cancel()
age, err := f.txStore.OldestNonTerminalTxAgeSeconds(ctxObs, f.chainID)
if err != nil {
f.lggr.Errorw("Failed to load oldest non-terminal transaction age for metrics", "err", err)
return
Expand Down
Loading