Add encodeCallMsg field-context errors and logTriggerConfig helper#201
Open
Add encodeCallMsg field-context errors and logTriggerConfig helper#201
Conversation
- encodeCallMsg now wraps hexToBase64 errors with field name context - Add logTriggerConfig() helper for validated hex-to-base64 log trigger config - Add validateHexByteLength for address (20 bytes) and topic (32 bytes) validation - Add 17 new tests for encodeCallMsg error context and logTriggerConfig
wentzeld
changed the title
Contributor
Author
|
accompanying docs pr smartcontractkit/documentation#3517 |
product-security-plaid-production
bot
requested review from
jeffrifwaldsmartcontract and
jmank88
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encodeCallMsgnow wrapshexToBase64errors with field name context (e.g.,Invalid hex in 'to' field of CallMsg: ...)logTriggerConfig()helper for building validated log trigger configs from hex-encoded addresses and topicsvalidateHexByteLengthfor address (20 bytes) and topic (32 bytes) validationWhy
Proto
bytesfields use base64 in JSON form. Passing raw hex strings directly causes silent data corruption — hex chars get interpreted as base64, producing wrong bytes with noerror. These helpers ensure correct encoding and catch mistakes at build time.
Test plan