fix: bound OCR verification work to prevent DoS - #181
Merged
Conversation
Add limits on OCR context size (1 MiB max) and signature count (max of 2x valid signers or 256, whichever is smaller). Split parseOCRProofData so ocr_context is decoded only after the event hash verification, avoiding large allocations on invalid reports. These bounds prevent CPU and memory exhaustion when verifying untrusted events.
|
👋 cmalec, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Update the test to use a valid OCR report (with correct workflow owner and event hash) so verification passes the hash check and reaches the context decoding step where the invalid hex is now rejected.
iljapavlovs
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OCR event verification processes attacker-controlled inputs without size or count limits:
Changes:
parseOCRProofDataso ocr_context is decoded only after the event hash verification, avoiding large allocations on invalid reportsReference: "Unbounded OCR proof processing in OcrEventVerifier causes client-side DoS" analysis-1
Reference: "Unbounded parsing and crypto verification in OcrEventVerifier causes application-wide DoS" analysis-2