Skip to content

BCM-4097: fix retry.IsTransient misclassifies ETIMEDOUT ("operation t… #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iljapavlovs merged 1 commit into from
Jul 29, 2026
Merged

BCM-4097: fix retry.IsTransient misclassifies ETIMEDOUT ("operation t… #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/retry/transient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ var transientNetworkIndicators = []string{
"connection refused",
"connection reset",
"timeout",
"timed out", // OS-level socket timeouts (ETIMEDOUT) render as "operation timed out", which "timeout" misses
"temporary failure",
"eof",
"broken pipe",
Expand Down
1 change: 1 addition & 0 deletions internal/retry/transient_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ func TestIsTransient(t *testing.T) {
"dial tcp: connection refused",
"read tcp: connection reset by peer",
"request timeout",
"read tcp 100.75.20.5:56710->10.198.65.200:443: read: operation timed out", // ETIMEDOUT phrasing
"unexpected EOF",
"write: broken pipe",
"lookup api.example.com: no such host",
Expand Down
Loading