Skip to content

Conversation

@davegill
Copy link
Collaborator

@davegill davegill commented Jun 10, 2020

modified: physics/mpas_atmphys_driver_microphysics.F
modified: physics/physics_sima/mp_wsm6.F
modified: physics/physics_wrf/module_mp_wsm6.F

Renames the top-level module
Removes commented out code
Fixes indenting
Pulls IF tests out of DO loops

Preparatory to putting the effective radius call into wsm6

No attempt to even compile yet

modified:   physics/mpas_atmphys_driver_microphysics.F
modified:   physics/physics_sima/mp_wsm6.F
modified:   physics/physics_wrf/module_mp_wsm6.F
@davegill
Copy link
Collaborator Author

@smileMchen
Ming,
It is OK to take a look now.

  1. Make sure the code compiles, runs, and gives bit-wise identical results.
  2. After you merge this PR with your fork, we want to push the call and surrounding infrastructure INTO the wsm6_run subroutine.

@smileMchen
Copy link
Owner

@davegill
Dave,
I will do and keep you updated. Thanks.

@smileMchen
Copy link
Owner

@davegill
Dave,
I checked out the code from your branch. There are a few issues, mainly the module name changes, that lead to compiling failure. I have fixed them and the code is compiled successfully.

Below is what I did today:
(1) keep the original name module_mp_wsm6.F
(2) rename the code mp_wsms.F to wsm6_run.F (this is to be consistent with wsm6_run_initial and wsm6_run_final)
(3) modify mpas_atmphys_driver_microphysics.F accordingly
(4) modify Makefile
(5) Follow the changes you made, I have manually done the following:
Remove commented out code
Fix indenting
Pull IF tests out of DO loops
I will commit these changes and DON'T merge your PR
(6) compile and run the test case to ensure bit-for-bit results

After (6) is OK, I will move on to work on the effectRad_wsm6 issue.

Ming

@davegill
Copy link
Collaborator Author

@smileMchen
MIng,
Sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants