Track observability business metric (metric 7) #4420

vcjana · 2025-11-24T08:37:10Z

Motivation and Context

Implements business metric tracking for observability providers per SEP User Agent 2.1 specification. The metric '7' (ObservabilityOtelMetrics) must be tracked when users configure OpenTelemetry metrics providers to help AWS understand observability usage patterns.

Description

This PR adds a new ObservabilityMetricDecorator that tracks the observability metric when OpenTelemetry metrics providers are configured through the global telemetry provider.

Implementation

The decorator registers an ObservabilityFeatureTrackerInterceptor that runs during request execution. It checks the global telemetry provider and uses type downcasting to detect if an OtelMeterProvider is configured:

Checks global telemetry provider via aws_smithy_observability::global::get_telemetry_provider()
Uses downcast_ref::<OtelMeterProvider>() for reliable type detection
Adds as_any() method to ProvideMeter trait to enable downcasting
Stores metric in interceptor state when OTel provider is detected

When an OpenTelemetry metrics provider is configured, the metric is tracked in the User-Agent header.

Checklist

I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

Note: This is a draft PR for review. The implementation successfully tracks OpenTelemetry metrics provider usage, which covers the SEP requirements for metric 7.

…dependencies

…any() implementation

github-actions · 2025-11-28T03:21:14Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

This change belongs to PR #4420 (observability metrics) where it's actually needed for testing, not in the endpoint override metric PR.

github-actions · 2025-11-28T20:39:58Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-11-28T23:26:00Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-11-30T23:13:40Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

…rom docs

github-actions · 2025-12-01T01:55:26Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-12-01T03:16:29Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-12-01T18:00:05Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

…-implementation # Conflicts: # aws/rust-runtime/Cargo.lock # rust-runtime/Cargo.lock

github-actions · 2025-12-01T19:57:10Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-12-01T21:00:06Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-12-02T03:44:42Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

landonxjames

Good start, couple of questions and suggestions. The biggest thing is figuring out what build issues you were encountering didn't allow you to test against the actual aws-smithy-observability-otel crate.

landonxjames · 2025-12-02T03:36:11Z

aws/rust-runtime/aws-inlineable/src/observability_feature.rs

+
+            // Check the provider name to detect OpenTelemetry without importing the otel crate
+            // This avoids compilation issues with the opentelemetry dependency
+            if meter_provider.provider_name() == "otel" {


I think this is ok, but this could be faked. I don't know that that is something we really need to defend against though.

If we used the as_any cast along with a downcast_ref we could guarantee that it was our implementation of Otel. What were the compilation issues we are avoiding with this strategy?

aws/rust-runtime/aws-inlineable/Cargo.toml

landonxjames · 2025-12-02T03:42:25Z

aws/sdk/integration-tests/dynamodb/tests/observability-metrics.rs

+}
+
+// Mock OTel meter provider for testing
+// This mimics the real OtelMeterProvider's type name without requiring the broken opentelemetry crate


How is it broken? It should work, we have some testing around it. The only thing I would expect to break would be it doesn't work on some of our exotic arch tests (powerpc maybe?).

I would really like to have a test that goes against the real OTel provider.

I initially used a mock because I was concerned about potential build issues with the opentelemetry crate (I had seen some comments about powerpc compatibility issues in the Cargo.toml). I'll update the test to use the actual implementation instead of the mock.

aws/sdk/integration-tests/dynamodb/tests/observability-metrics.rs

aws/sdk/integration-tests/dynamodb/Cargo.toml

rust-runtime/aws-smithy-observability/src/lib.rs

landonxjames · 2025-12-02T03:58:56Z

rust-runtime/aws-smithy-observability/src/meter.rs

+    /// The default implementation returns a reference to the unit type,
+    /// which will fail any downcast attempts. Implementations should override
+    /// this to return `self` for proper type inspection.
+    fn as_any(&self) -> &dyn std::any::Any {


This new method doesn't seem to be used anywhere? I think it probably should be though so we can match on the actual type instead of on a name that could be set to anything.

If we do keep this it should either be a real implementation (return &self) or not implemented so implementers of the trait have to implement it themselves. But returning an incorrect type () is not the behavior we want.

github-actions · 2025-12-02T21:14:56Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-12-02T22:07:20Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-12-03T20:40:56Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-12-03T22:11:47Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-12-03T23:06:20Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-12-04T03:10:23Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
No codegen difference in the Server Test Python
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

vcjana added 2 commits November 24, 2025 00:33

Track observability business metric (metric 7)

740742f

Fix formatting, bump codegen version to 0.1.7, and add observability …

30648d2

…dependencies

vcjana force-pushed the observability-metrics-implementation branch from 3325a0b to 30648d2 Compare November 24, 2025 16:57

Move ObservabilityOtelMetrics to SmithySdkFeature and add default as_…

3e09af7

…any() implementation

vcjana force-pushed the observability-metrics-implementation branch from f9f1c7e to 0c38ac5 Compare November 28, 2025 02:13

Make as_any() required method for trait objects

02e7b83

vcjana force-pushed the observability-metrics-implementation branch from 0c38ac5 to 02e7b83 Compare November 28, 2025 02:57

ysaito1001 mentioned this pull request Nov 28, 2025

Track endpoint override business metric (metric N) #4419

Merged

2 tasks

vcjana added a commit that referenced this pull request Nov 28, 2025

Remove unrelated noop module visibility change

9656a6e

This change belongs to PR #4420 (observability metrics) where it's actually needed for testing, not in the endpoint override metric PR.

Fix opentelemetry 0.26.0 dependencies and test compatibility

869532b

vcjana force-pushed the observability-metrics-implementation branch from e48ccee to 869532b Compare November 30, 2025 22:52

fix(observability): Add provider_name() method and hide noop module f…

e7f0f5c

…rom docs

vcjana force-pushed the observability-metrics-implementation branch 2 times, most recently from 26502b9 to 4bdc5a1 Compare December 1, 2025 17:32

vcjana force-pushed the observability-metrics-implementation branch 2 times, most recently from 14ab3db to 433fbe0 Compare December 1, 2025 19:30

Apply rustfmt and bump aws-smithy-observability to 0.1.6

1fcff09

vcjana force-pushed the observability-metrics-implementation branch from 433fbe0 to 1fcff09 Compare December 1, 2025 19:32

Merge remote-tracking branch 'origin/main' into observability-metrics…

6d6de50

…-implementation # Conflicts: # aws/rust-runtime/Cargo.lock # rust-runtime/Cargo.lock

Remove trailing whitespace

fd8f587

Merge branch 'main' into observability-metrics-implementation

655fdb3

landonxjames reviewed Dec 2, 2025

View reviewed changes

vcjana added 2 commits December 2, 2025 12:50

Fix as_any trait and address review comments

595e884

Merge branch 'main' into observability-metrics-implementation

703af49

Allow dead_code in test utils

389aefe

Bump version to 0.2.0

f8aa750

vcjana force-pushed the observability-metrics-implementation branch from 9ed940d to f8aa750 Compare December 3, 2025 21:24

Merge branch 'main' into observability-metrics-implementation

ee5e070

Bump aws-smithy-observability version to 0.3.0

efc995e

Bump aws-smithy-observability version to 0.2.0

85a14fd

Add default impl for as_any()

7f0b853

Track observability business metric (metric 7) #4420

Are you sure you want to change the base?

Track observability business metric (metric 7) #4420

Uh oh!

Conversation

vcjana commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Description

Implementation

Checklist

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 28, 2025

Uh oh!

github-actions bot commented Nov 30, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 1, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

landonxjames left a comment

Choose a reason for hiding this comment

Uh oh!

landonxjames Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

landonxjames Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

vcjana Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

landonxjames Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 2, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 3, 2025

Uh oh!

github-actions bot commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vcjana commented Nov 24, 2025 •

edited

Loading