Fix Content-Type and Accept headers for event stream in RPC v2 CBOR
#4427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
landonxjames
approved these changes
Dec 1, 2025
Contributor
landonxjames
left a comment
landonxjames
left a comment
There was a problem hiding this comment.
One comment on some of the tests, not a blocker
...rust/codegen/client/smithy/protocols/eventstream/ClientEventStreamMarshallerGeneratorTest.kt
Outdated
Show resolved
Hide resolved
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Collaborator
|
We need to consider backwards compatibility here because there are servers that are relying on the old behavior. I fixed servers in the last release, but I'm a little bit worried about any in the wild servers that have not updated their list. Can the client send both accept headers? |
This commit addresses #4427 (comment)
This commit addresses #4427 (comment)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
rcoh
approved these changes
Dec 4, 2025
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
deleted the
ysaito/fix-request-headers-for-rpc-v2-event-stream
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#4421
Description
This PR fixes setting the request headers in question for event stream in RPC v2 CBOR according to the spec, specifically
Content-Typeheader MUST beapplication/vnd.amazon.eventstream.Acceptheader MUST beapplication/vnd.amazon.eventstream.Testing
ClientEventStreamMarshallerGeneratorTest.ktto include verification for those headersThe spec regarding response header
For requests with all other response types: the value of the Accept header MUST be application/cborhas already been covered by protocol tests.Checklist
.changelogdirectory, specifying "client," "server," or both in theapplies_tokey..changelogdirectory, specifying "aws-sdk-rust" in theapplies_tokey.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.