Skip to content

Conversation

@yefrig
Copy link
Contributor

@yefrig yefrig commented Nov 6, 2025

Add a cli-distributions job that builds Smithy CLI executables for all target platforms using the :smithy-cli:images Gradle task. This ensures PRs that update dependencies are validated against the distribution build process.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Add a `cli-distributions` job that builds Smithy CLI executables for
all target platforms using the `:smithy-cli:images` Gradle task. This
ensures PRs that update dependencies are validated against the
distribution build process.
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

This pull request does not contain a staged changelog entry. To create one, use the ./.changes/new-change command. For example:

./.changes/new-change --pull-requests "#2829" --type feature --description "Add CLI distributions build job to CI workflow"

Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See ./.changes/README or run ./.changes/new-change -h for more information.

@yefrig
Copy link
Contributor Author

yefrig commented Nov 6, 2025

Note that the newly added CI check will fail with:

Execution failed for task ':smithy-cli:runtimeZip'.
> Could not find method createZip() for arguments [/home/runner/work/smithy/smithy/smithy-cli/build/image/smithy-cli-linux-x86_64, /home/runner/work/smithy/smithy/smithy-cli/build/image/smithy-cli-linux-x86_64.zip] on object of type org.beryx.runtime.impl.RuntimeZipTaskImpl.

This is due to an existing issue that will be fixed by #2828. The purpose of this PR is to add CI checks that surface such issues earlier.

@yefrig yefrig marked this pull request as ready for review November 6, 2025 18:53
@yefrig yefrig requested a review from a team as a code owner November 6, 2025 18:53
@yefrig yefrig requested a review from JordonPhillips November 6, 2025 18:53
@yefrig yefrig merged commit 6bfd2be into smithy-lang:main Nov 6, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants