-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulate Gen 1 Fight Button for Wrap #2327
Conversation
These feel like they should be in finalDecisionMove, rather than their own variables? Maybe finalDecisionMove should be a string enum of possible reasons? Ditto for |
I mean, sure? My biggest concern is that maybePartiallyTrapping takes a 'string' argument for a move so im not sure how to go about it |
We got to an understanding on Discord. The client only needs to know whether it's possible to cancel after using a move, and whether it's possiblce to cancel after switching, and a reason for each. I won't merge until that's in. |
99b3a35
to
1ef152f
Compare
Co-authored-by: Guangcong Luo <[email protected]>
To be clear, the text is not finalized, but it makes sense to make the current version playable while waiting for the RBY council to slowly deliberate on it. |
Adds a warning if you are partial trapping/partially trapped, also collaborated with @InAShellnut
To be merged with smogon/pokemon-showdown#10936