Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broadcast Restriction on avatar. #2335

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

WifiLatency
Copy link
Contributor

Depends on smogon/pokemon-showdown#10961

Client end of implementing the suggestion: https://www.smogon.com/forums/threads/avatar-avatar-to-be-broadcastable-showing-the-avatar-sprite-and-the-credit.3759095/

Removes the restriction on sending a broadcast prefix '!' with the avatar command to allow for users to broadcast it in chat. Prevents caching the selected avatar when using the '!' prefix to send the command.

@Zarel
Copy link
Member

Zarel commented Mar 11, 2025

Hmm. This functionality is very different from /avatar. Maybe it should be a different command? How do other commands work?

Okay, I guess this sorta matches stuff like !roomintro? ...it's not a perfect match for any existing command, but oh well, close enough, I see no harm in this.

@Zarel Zarel merged commit a062944 into smogon:master Mar 11, 2025
1 check passed
@Zarel
Copy link
Member

Zarel commented Mar 11, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants